Skip to content

Update AESEncryptAlgorithm.java#10830

Merged
terrymanu merged 10 commits into
apache:masterfrom
nanzheng:master
Jun 29, 2021
Merged

Update AESEncryptAlgorithm.java#10830
terrymanu merged 10 commits into
apache:masterfrom
nanzheng:master

Conversation

@nanzheng

@nanzheng nanzheng commented Jun 16, 2021 •
edited by terrymanu
Loading

Copy link
Copy Markdown
Contributor

improvement base64 encode decode performance. Totally increase almost over 200%

Fixes apache Base64 encode decode low performance issue.

@nanzheng
Update AESEncryptAlgorithm.java
3ef7bd8 
improvement base64 encode decode performance. Totally increase almost over 200%
@tristaZero

tristaZero commented Jun 16, 2021

Copy link
Copy Markdown
Contributor

Hi @nanzheng Thanks, If this PR can improve the performance, that will be appreciated. But could you look at non-passed CI tests?

@tristaZero tristaZero added this to the 5.0.0-RC1 milestone Jun 16, 2021
nanzheng
nanzheng commented Jun 17, 2021
View reviewed changes

@nanzheng nanzheng left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed useless import class.

nanzheng
nanzheng commented Jun 17, 2021
View reviewed changes

@nanzheng nanzheng left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add import DatatypeConverter line

nanzheng
nanzheng commented Jun 17, 2021
View reviewed changes

@nanzheng nanzheng left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add trycatch

@nanzheng

nanzheng commented Jun 17, 2021

Copy link
Copy Markdown
Contributor Author

Hi @nanzheng Thanks, If this PR can improve the performance, that will be appreciated. But could you look at non-passed CI tests?

Error: Failed to execute goal on project shardingsphere-infra-optimize: Could not resolve dependencies for project org.apache.shardingsphere:shardingsphere-infra-optimize:jar:5.0.0-RC1-SNAPSHOT: Failed to collect dependencies at org.apache.calcite:calcite-core:jar:1.26.0: Failed to read artifact descriptor for org.apache.calcite:calcite-core:jar:1.26.0: Could not transfer artifact org.apache.calcite:calcite-core:pom:1.26.0 from/to central (https://repo.maven.apache.org/maven2): Transfer failed for https://repo.maven.apache.org/maven2/org/apache/calcite/calcite-core/1.26.0/calcite-core-1.26.0.pom: Connection reset -> [Help 1]
Error:
Error: To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: Re-run Maven using the -X switch to enable full debug logging.
Error:
Error: For more information about the errors and possible solutions, please read the following articles:
Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
Error:
Error: After correcting the problems, you can resume the build with the command
Error: mvn -rf :shardingsphere-infra-optimize
Error: Process completed with exit code 1.
CI building press got above errors, but there is nothing commit code import this infra module. Please help to find how does it happen. thanks.

@codecov-commenter

codecov-commenter commented Jun 17, 2021

Copy link
Copy Markdown

Codecov Report

Merging #10830 (a781678) into master (031f2ad) will increase coverage by 0.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #10830      +/-   ##
============================================
+ Coverage     65.63%   65.65%   +0.01%     
  Complexity      718      718              
============================================
  Files          1809     1810       +1     
  Lines         30925    30927       +2     
  Branches       5573     5575       +2     
============================================
+ Hits          20298    20304       +6     
+ Misses         9011     9008       -3     
+ Partials       1616     1615       -1
Impacted Files Coverage Δ
...gsphere/encrypt/algorithm/AESEncryptAlgorithm.java 83.33% <71.42%> (-6.67%) ⬇️
...end/communication/DatabaseCommunicationEngine.java 30.35% <0.00%> (-0.56%) ⬇️
...ore/resultset/ShardingSphereResultSetMetaData.java 5.55% <0.00%> (-0.16%) ⬇️
...rser/sql/common/util/WhereSegmentExtractUtils.java
...rser/sql/common/util/SafeNumberOperationUtils.java
...arser/sql/common/util/SafeNumberOperationUtil.java 74.28% <0.00%> (ø)
...e/sql/parser/sql/common/util/WhereExtractUtil.java 0.00% <0.00%> (ø)
...ql/parser/sql/common/util/SubqueryExtractUtil.java 0.00% <0.00%> (ø)
...a/binder/statement/dml/SelectStatementContext.java 81.05% <0.00%> (+1.05%) ⬆️
...m/sharding/datetime/IntervalShardingAlgorithm.java 82.60% <0.00%> (+2.60%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 031f2ad...a781678. Read the comment docs.

terrymanu
terrymanu requested changes Jun 21, 2021
View reviewed changes
Comment thread ...rypt-core/src/main/java/org/apache/shardingsphere/encrypt/algorithm/AESEncryptAlgorithm.java Outdated
Comment thread ...rypt-core/src/main/java/org/apache/shardingsphere/encrypt/algorithm/AESEncryptAlgorithm.java Outdated
@terrymanu

terrymanu commented Jun 21, 2021

Copy link
Copy Markdown
Member

Hi @nanzheng Thanks, If this PR can improve the performance, that will be appreciated. But could you look at non-passed CI tests?

Error: Failed to execute goal on project shardingsphere-infra-optimize: Could not resolve dependencies for project org.apache.shardingsphere:shardingsphere-infra-optimize:jar:5.0.0-RC1-SNAPSHOT: Failed to collect dependencies at org.apache.calcite:calcite-core:jar:1.26.0: Failed to read artifact descriptor for org.apache.calcite:calcite-core:jar:1.26.0: Could not transfer artifact org.apache.calcite:calcite-core:pom:1.26.0 from/to central (https://repo.maven.apache.org/maven2): Transfer failed for https://repo.maven.apache.org/maven2/org/apache/calcite/calcite-core/1.26.0/calcite-core-1.26.0.pom: Connection reset -> [Help 1]
Error:
Error: To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: Re-run Maven using the -X switch to enable full debug logging.
Error:
Error: For more information about the errors and possible solutions, please read the following articles:
Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
Error:
Error: After correcting the problems, you can resume the build with the command
Error: mvn -rf :shardingsphere-infra-optimize
Error: Process completed with exit code 1.
CI building press got above errors, but there is nothing commit code import this infra module. Please help to find how does it happen. thanks.

The error is related with #10810

nanzheng
nanzheng commented Jun 25, 2021
View reviewed changes

@nanzheng nanzheng left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change exception handle

terrymanu
terrymanu requested changes Jun 25, 2021
View reviewed changes
Comment thread ...rypt-core/src/main/java/org/apache/shardingsphere/encrypt/algorithm/AESEncryptAlgorithm.java Outdated
}

@SneakyThrows(GeneralSecurityException.class)
@SneakyThrows

@terrymanu terrymanu Jun 25, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please SneakyThrows accurate exception

nanzheng
nanzheng commented Jun 28, 2021
View reviewed changes

@nanzheng nanzheng left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change excepiton

@terrymanu

terrymanu commented Jun 29, 2021

Copy link
Copy Markdown
Member

@nanzheng The checkstyle is failed, I just merge it and revise for you, please pay attention.

@terrymanu terrymanu merged commit 9845d1b into apache:master Jun 29, 2021
@terrymanu terrymanu mentioned this pull request Jun 29, 2021
Merged
TeslaCN pushed a commit that referenced this pull request Jun 29, 2021
@terrymanu
Revise #10830 (#11049)
d70810a
@strongduanmu strongduanmu mentioned this pull request Jun 29, 2021
Merged
@menghaoranss menghaoranss modified the milestones: 5.0.0-RC1, 5.0.0 Oct 26, 2021
@TeslaCN TeslaCN mentioned this pull request Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terrymanu terrymanu terrymanu approved these changes

Assignees

No one assigned

Labels

feature: encrypt type: enhancement

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nanzheng @tristaZero @codecov-commenter @terrymanu @menghaoranss