[fix] Fix DLQ producer name conflicts when multiples consumers send messages to DLQ#1156
Merged
Merged
Conversation
Member
Author
|
@RobertIndie PTAL |
RobertIndie
approved these changes
Jan 12, 2024
zzzming
approved these changes
Jan 12, 2024
zzzming
left a comment
Contributor
There was a problem hiding this comment.
we just found this issue. Thanks for fixing it.
RobertIndie
pushed a commit
that referenced
this pull request
Jan 15, 2024
…essages to DLQ (#1156) ### Motivation To keep consistent with the Java client. Releted PR: apache/pulsar#21890 ### Modifications Set DLQ producerName `fmt.Sprintf("%s-%s-%s-DLQ", r.topicName, r.subscriptionName, r.consumerName)` (cherry picked from commit 4e13822)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
To keep consistent with the Java client.
Releted PR: apache/pulsar#21890
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Set DLQ producerName
fmt.Sprintf("%s-%s-%s-DLQ", r.topicName, r.subscriptionName, r.consumerName)Verifying this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation