Skip to content

Conversation

@BewareMyPower
Copy link
Contributor

No description provided.

@BewareMyPower BewareMyPower changed the title Verify 3.2.0 candidate 5 [TEST] Verify 3.2.0 candidate 5 Feb 2, 2024
@BewareMyPower BewareMyPower marked this pull request as draft February 2, 2024 03:34
BewareMyPower added a commit to BewareMyPower/pulsar that referenced this pull request Feb 2, 2024
…licies before loading topics

### Motivation

apache#21445 introduces an implicit
requirement that if the topic policies cannot be loaded,
`BrokerService#getTopic` will fail and then the client will retry
loading the topic.

It could break some existing usages like the tests in the C++
client: apache/pulsar-client-cpp#394

This change is applied only to avoid the race condition when unloading a
namespace bundle. However, the client should not fail if the topic-level
policies are not available.

### Modifications

If the topic policies cannot be loaded due to a non-retryable error, we
should not fail the `getTopic`. For retryable errors, the client will
still retry until the broker gets the topic-level policies successfully
after some attempts.

Modify `TokenAuthenticatedProducerConsumerTest` to protect the change.
@BewareMyPower BewareMyPower deleted the bewaremypower/verify-3.2.0 branch February 5, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant