[C++] Remove namespace check for MultiTopicsConsumerImpl #9520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
And I've a question. Should we also add tests for Python client? Since it only affects |
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
I found there's an existed Python test for multiple topics, I'll fix the test. |
zymap
reviewed
Feb 8, 2021
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot run-failure-checks |
zymap
approved these changes
Feb 8, 2021
sijie
approved these changes
Feb 8, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Feb 8, 2021
Fixes #9449 ### Motivation This is a catchup work for #5716 that supports multiple topic subscriptions across multiple namespaces. ### Modifications - Move the check for namespace in `MultiTopicsConsumerImpl` to `PatternMultiTopicsConsumerImpl` that uses a regex subscription. - Fix the existed tests for subscription on topics across different namespaces. ### Verifying this change This change is already covered by existing tests, such as *BasicEndToEndTest.testMultiTopicsConsumerDifferentNamespace*. (cherry picked from commit 69e9322)
codelipenghui
pushed a commit
to streamnative/pulsar-archived
that referenced
this pull request
Feb 8, 2021
Fixes apache#9449 ### Motivation This is a catchup work for apache#5716 that supports multiple topic subscriptions across multiple namespaces. ### Modifications - Move the check for namespace in `MultiTopicsConsumerImpl` to `PatternMultiTopicsConsumerImpl` that uses a regex subscription. - Fix the existed tests for subscription on topics across different namespaces. ### Verifying this change This change is already covered by existing tests, such as *BasicEndToEndTest.testMultiTopicsConsumerDifferentNamespace*. (cherry picked from commit 69e9322) (cherry picked from commit 3031550)
codelipenghui
pushed a commit
that referenced
this pull request
Feb 18, 2021
Fixes #9449 ### Motivation This is a catchup work for #5716 that supports multiple topic subscriptions across multiple namespaces. ### Modifications - Move the check for namespace in `MultiTopicsConsumerImpl` to `PatternMultiTopicsConsumerImpl` that uses a regex subscription. - Fix the existed tests for subscription on topics across different namespaces. ### Verifying this change This change is already covered by existing tests, such as *BasicEndToEndTest.testMultiTopicsConsumerDifferentNamespace*. (cherry picked from commit 69e9322)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9449
Motivation
This is a catchup work for #5716 that supports multiple topic subscriptions across multiple namespaces.
Modifications
MultiTopicsConsumerImpltoPatternMultiTopicsConsumerImplthat uses a regex subscription.Verifying this change
This change is already covered by existing tests, such as BasicEndToEndTest.testMultiTopicsConsumerDifferentNamespace.