Do not use a static map of listeners in TopicPoliciesService #9486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Feb 5, 2021
sijie
approved these changes
Feb 5, 2021
eolivelli
approved these changes
Feb 5, 2021
Contributor
eolivelli
left a comment
There was a problem hiding this comment.
good catch !
is this something to fix in 2.7 branch ?
Contributor
|
@lhotari FYI |
codelipenghui
pushed a commit
that referenced
this pull request
Feb 5, 2021
Maybe CI jobs are failing with OOM in the brokers unit tests. The Surefire worker is configured with 4 processes, each with xmx of 1G. The problem was introduced in #7863 where a static map of listeners was added to an interface. That makes that map to contain all the `PulsarService` instances created during the tests execution and keeping references to everything else. The map should instead be scoped to the specific instance. (cherry picked from commit 31ee454)
merlimat
added a commit
to merlimat/pulsar
that referenced
this pull request
Apr 6, 2021
…9486) ### Motivation Maybe CI jobs are failing with OOM in the brokers unit tests. The Surefire worker is configured with 4 processes, each with xmx of 1G. The problem was introduced in apache#7863 where a static map of listeners was added to an interface. That makes that map to contain all the `PulsarService` instances created during the tests execution and keeping references to everything else. The map should instead be scoped to the specific instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Maybe CI jobs are failing with OOM in the brokers unit tests. The Surefire worker is configured with 4 processes, each with xmx of 1G.
The problem was introduced in #7863 where a static map of listeners was added to an interface. That makes that map to contain all the
PulsarServiceinstances created during the tests execution and keeping references to everything else.The map should instead be scoped to the specific instance.