Fix dispatchRate is overwritten #8004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Sep 8, 2020
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Oct 3, 2020
Fixes apache#7863 ### Motivation 1) Topic level policy will be overwritten by namespace level 2) After removing the topic level policy, `DispatchLimiter` does not take effect, the namespace level policy should be used ### Modifications 1）If there is a topic-level policy, it will not be overwritten by the namespace-level policy when the policy is updated 2）When removing topic-level policy, namespace-level policy will be used. If the namespace-level policy does not exist, the broker level will be used ### Verifying this change unit test: TopicPoliciesTest#testPolicyOverwrittenByNamespaceLevel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7863
Motivation
DispatchLimiterdoes not take effect, the namespace level policy should be usedModifications
1）If there is a topic-level policy, it will not be overwritten by the namespace-level policy when the policy is updated
2）When removing topic-level policy, namespace-level policy will be used. If the namespace-level policy does not exist, the broker level will be used
Verifying this change
unit test:
TopicPoliciesTest#testPolicyOverwrittenByNamespaceLevel