[Issue 7759] Support set Max Consumer on topic level. #7968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
@codelipenghui @jianyun8023 @jiazhai PTAL. Thanks. |
jianyun8023
reviewed
Sep 4, 2020
Comment on lines
2420
to
2434
| protected void internalGetMaxConsumers(AsyncResponse asyncResponse) { | ||
| validateAdminAccessForTenant(namespaceName.getTenant()); | ||
| validatePoliciesReadOnlyAccess(); | ||
| if (topicName.isGlobal()) { | ||
| validateGlobalNamespaceOwnership(namespaceName); | ||
| } | ||
| checkTopicLevelPolicyEnable(); | ||
| Optional<Integer> maxConsumers = getTopicPolicies(topicName) | ||
| .map(TopicPolicies::getMaxConsumerPerTopic); | ||
| if (!maxConsumers.isPresent()) { | ||
| asyncResponse.resume(Response.noContent().build()); | ||
| } else { | ||
| asyncResponse.resume(maxConsumers.get()); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
It is not recommended to use AsyncResponse, just return the value directly.
more info to see #7884
Contributor
Author
There was a problem hiding this comment.
How about making a new PR to resolve them all?
Contributor
There was a problem hiding this comment.
I think the new code can comply with this rule.
| Assert.assertEquals(getMaxConsumers, maxConsumers); | ||
|
|
||
| admin.topics().deletePartitionedTopic(persistenceTopic, true); | ||
| admin.topics().deletePartitionedTopic(testTopic, true); |
Contributor
There was a problem hiding this comment.
remove admin.topics().deletePartitionedTopic(testTopic, true);
Contributor
Author
There was a problem hiding this comment.
'testTopic' was created in BeforeMethod.
# Conflicts: # pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java
Contributor
Author
|
/pulsarbot run-failure-checks |
Comment on lines
156
to
158
| jcommander.addCommand("get-maxConsumers", new GetMaxConsumers()); | ||
| jcommander.addCommand("set-maxConsumers", new SetMaxConsumers()); | ||
| jcommander.addCommand("remove-maxConsumers", new RemoveMaxConsumers()); |
Contributor
There was a problem hiding this comment.
Suggested change
| jcommander.addCommand("get-maxConsumers", new GetMaxConsumers()); | |
| jcommander.addCommand("set-maxConsumers", new SetMaxConsumers()); | |
| jcommander.addCommand("remove-maxConsumers", new RemoveMaxConsumers()); | |
| jcommander.addCommand("get-max-consumers", new GetMaxConsumers()); | |
| jcommander.addCommand("set-max-consumers", new SetMaxConsumers()); | |
| jcommander.addCommand("remove-max-consumers", new RemoveMaxConsumers()); |
Contributor
There was a problem hiding this comment.
And please also update the max producers as the above pattern.
codelipenghui
approved these changes
Sep 7, 2020
Contributor
Author
|
/pulsarbot run-failure-checks |
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Oct 3, 2020
Fix [https://github.com/apache/pulsar/issues/7759](https://github.com/apache/pulsar/issues/7759), and master issue [https://github.com/apache/pulsar/issues/2688](https://github.com/apache/pulsar/issues/2688) ### Motivation Support set/get/remove maxConsumers on a topic level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7759, and master issue #2688
Motivation
Support set/get/remove maxConsumers on a topic level.
Verifying this change
new unit test added.