Close the previous reader of the health check topic#7724
Merged
codelipenghui merged 1 commit intoAug 3, 2020
Merged
Conversation
sijie
approved these changes
Aug 3, 2020
Member
|
@wolfstudy to help cherry-pick to both branch-2.5 and branch-2.6 |
wolfstudy
pushed a commit
that referenced
this pull request
Aug 4, 2020
(cherry picked from commit ca98a89)
Member
Sure, already cherry-pick the pull request to branch-2.5 and branch-2.6 |
wolfstudy
pushed a commit
that referenced
this pull request
Aug 4, 2020
(cherry picked from commit ca98a89)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
2 tasks
2 tasks
codelipenghui
pushed a commit
that referenced
this pull request
Mar 14, 2022
…#14658) Original PR #14367 Because the PR #14367 is based on PR #14091, so I want to cherry-pick these two PRs to branch-2.9, the PR #13525 is also needed. --- Fix Issue: #14362 ### Motivation According to relative PR #7724, we will force delete all subscriptions when calling ``healthCheck`` REST API. but it has a race condition when two threads call this API. Please consider this case: > Thread A: Clean up all subscriptions, then create a reader. > Thread B: Prepare to force delete all subscriptions. So, in this case, the reader of thread A is deleted and then an NPE or other exception occurs. ### Modifications - Use ``Completable#handle`` to fix problem 1, the reader needs to be closed regardless of whether there is an exception. - Recheck the subscription after closing reading, and force deletion if it still exists after closing reading. - Added multi-threaded tests for health checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications
Close the previous reader of the health check topic. Not sure what caused the reader to not close properly, this PR tries to delete the previous reader of the health check to make sure the previous readers can be closed.
If the previous reader can't be closed, the backlog of the health check topic will keep increasing. According to the broker heap dump, there is more than one reader can't be closed.
This PR is related to #7589
Verifying this change
The problem is hard to reproduce.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation