Support KeyValue Schema Use Null Key And Null Value #7139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdd94ec to
c1e56ed
Compare
1f02836 to
25fcd02
Compare
Contributor
|
/pulsarbot run-failure-checks |
| optional int32 chunk_id = 29; | ||
|
|
||
| // Indicate if the message key is set | ||
| optional bool null_key = 30 [default = false]; |
Contributor
There was a problem hiding this comment.
It's better to use null_partition_key here since we have partition_key and ordering key in the proto. Use null_partition_key will be more accurate.
| // Indicate if the message payload value is set | ||
| optional bool null_value = 9 [ default = false ]; | ||
| // Indicate if the message key is set | ||
| optional bool null_key = 10 [ default = false]; |
Contributor
There was a problem hiding this comment.
Same as the above comment.
Contributor
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Jun 4, 2020
Member
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Jun 4, 2020
1 task
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Jun 5, 2020
…te-update * 'website-update' of github.com:zeo1995/pulsar: (432 commits) Fixed ordering issue in KeyShared dispatcher when adding consumer (apache#7106) Fix Duplicated messages are sent to dead letter topic apache#6960 (apache#7021) [Issue 2793][Doc]--Update the TLS hostname verification for CPP and Python clients (apache#7162) [Doc]--set netty mex frame size (apache#7174) [Doc] Update for the maximum message size (apache#7171) Fixed KeyShared consumers getting stuck on delivery (apache#7105) [apache#6003][pulsar-functions] Possibility to add builtin Functions (apache#6895) [Issue 6921][pulsar-broker-common] Replaced "Paths.get(...).getParent()", because it's system dependent and uses '\' as path separator on Windows (apache#6992) Improve broker unit test CI (apache#7173) Fix typo in exception message (apache#7027) Support KeyValue Schema Use Null Key And Null Value (apache#7139) [Doc]--Update documents for support consumer priority level in failover mode (apache#7136) Add schema config to cpp and cgo docs. (apache#7137) [Doc]--Update for the maximum message size (apache#7160) [C++] Expose ZSTD and Snappy compression to C API (apache#7014) [pulsar-proxy] add proxyLogLevel into config file (apache#6948) Add multi-hosts example for bookkeeperMetadataServiceUri (apache#6998) support for termination of partitioned topic (apache#6126) Use pure-java Air-Compressor instead of JNI based libraries (apache#5390) [Issues 5709]remove the namespace checking (apache#5716) ... # Conflicts: # site2/website/scripts/split-swagger-by-version.js
Contributor
|
This does not work as described here |
cdbartholomew
pushed a commit
to kafkaesque-io/pulsar
that referenced
this pull request
Jul 24, 2020
Fixes apache#4804 Thanks, @nlu90, work at apache#6384. ### Motivation Currently, the KeyValue schema doesn't handle `null` key and `null` value well.
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Fixes apache#4804 Thanks, @nlu90, work at apache#6384. ### Motivation Currently, the KeyValue schema doesn't handle `null` key and `null` value well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4804
Thanks, @nlu90, work at #6384.
Motivation
Currently, the KeyValue schema doesn't handle
nullkey andnullvalue well.Modifications
Make the KeyValue schema support
nullkey andnullvalueVerifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation