[Issue 6283][tiered-storage] Offload policies per namespace #6422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
acb38ef to
4adb758
Compare
Member
|
@gaoran10 @codelipenghui can you review this pull request? |
codelipenghui
requested changes
Mar 8, 2020
Contributor
codelipenghui
left a comment
There was a problem hiding this comment.
If offload_threshold and offload_deletion_lag_ms are specified before, It's better to merge offload_threshold and offload_deletion_lag_ms of Policies into OffloadPolicies when users first use set-offload-policies. Otherwise, will cause inconsistency with the previous configuration. And please add a test to cover it.
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
Outdated
Show resolved
Hide resolved
33f1c2f to
c537080
Compare
codelipenghui
approved these changes
Mar 12, 2020
099c42d to
198338e
Compare
198338e to
39e929e
Compare
Contributor
|
@gaoran10 Please help review this PR, thanks. |
Contributor
|
Looks good to me! Good work. |
sijie
approved these changes
Mar 28, 2020
Member
|
conflict with #6717, marked with 2.5.2, and merge into branch-2.5 |
jiazhai
pushed a commit
that referenced
this pull request
May 8, 2020
cdbartholomew
added a commit
to kafkaesque-io/pulsar
that referenced
this pull request
May 25, 2020
…pache#6422)" This reverts commit c3fa923.
Member
|
Docs have been added: |
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
) Fixes apache#6283 ### Modifications Define and use custom deletionLag and threshold for offloadpolicies per ns. All is stuff is required for apache#6354.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6283
Modifications
Define and use custom deletionLag and threshold for offloadpolicies per ns.
All is stuff is required for #6354.
Verifying this change
This change is already covered by existing tests, such as .
Does this pull request potentially affect one of the following parts:
Documentation