Skip to content

[Reopen][Issue 5597]retry when getPartitionedTopicMetadata failed #5734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wolfstudy merged 7 commits into from
Dec 3, 2019
Merged

[Reopen][Issue 5597]retry when getPartitionedTopicMetadata failed #5734

wolfstudy merged 7 commits into from
Dec 3, 2019

Conversation

@wolfstudy
Copy link
Member

@wolfstudy wolfstudy commented Nov 25, 2019

Signed-off-by: xiaolong.ran ranxiaolong716@gmail.com

Fixes #5597

Motivation

When using a multi-broker service url to create a producer, if the connection to the first broker failed, the creation will fail.

Modifications

Add backoff retries when getting partitioned metadata from brokers.

copy #5603

@wolfstudy
[Issue 5597][pulsar-client-java]retry when getPartitionedTopicMetadat…
171ec08 
…a failed

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
remove unuse code
eca62d8 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy wolfstudy changed the title [Issue 5597]retry when getPartitionedTopicMetadata failed [Reopen][Issue 5597]retry when getPartitionedTopicMetadata failed Nov 25, 2019
@wolfstudy wolfstudy added this to the 2.5.0 milestone Nov 25, 2019
@wolfstudy wolfstudy self-assigned this Nov 25, 2019
@wolfstudy
Copy link
Member Author

wolfstudy commented Nov 25, 2019

run cpp tests
run java8 tests

@sijie sijie added area/client type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages labels Nov 25, 2019
@sijie
Copy link
Member

sijie commented Nov 25, 2019

run java8 tests

1 similar comment
@jiazhai
Copy link
Member

jiazhai commented Nov 26, 2019

run java8 tests

@wolfstudy
fix ci error
b6b6521 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@sijie
Copy link
Member

sijie commented Nov 26, 2019

run java8 tests

@wolfstudy
fix ci error
1d94539 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
Copy link
Member Author

wolfstudy commented Nov 27, 2019

run java8 tests

@wolfstudy
Copy link
Member Author

wolfstudy commented Nov 27, 2019

run java8 tests
run cpp tests

@sijie
Copy link
Member

sijie commented Nov 27, 2019

run java8 tests

1 similar comment
@wolfstudy
Copy link
Member Author

wolfstudy commented Nov 28, 2019

run java8 tests

@wolfstudy
Copy link
Member Author

wolfstudy commented Nov 29, 2019

run java8 tests
run cpp tests

@wolfstudy
Copy link
Member Author

wolfstudy commented Nov 29, 2019

run cpp tests

@sijie
Copy link
Member

sijie commented Nov 30, 2019

run java8 tests

@codelipenghui
Copy link
Contributor

codelipenghui commented Dec 1, 2019

run java8 tests

1 similar comment
@wolfstudy
Copy link
Member Author

wolfstudy commented Dec 2, 2019

run java8 tests

@sijie
Copy link
Member

sijie commented Dec 2, 2019

@wolfstudy

	Test Result (7 failures / +7)
org.apache.pulsar.broker.service.BrokerServiceTest.testLookupThrottlingForClientByClient
org.apache.pulsar.broker.service.BrokerServiceThrottlingTest.testLookupThrottlingForClientByBroker
org.apache.pulsar.broker.service.PeerReplicatorTest.testPeerClusterTopicLookup
org.apache.pulsar.broker.service.PeerReplicatorTest.testPeerClusterTopicLookup
org.apache.pulsar.broker.service.PeerReplicatorTest.testPeerClusterTopicLookup
org.apache.pulsar.client.api.TlsProducerConsumerTest.testTlsClientAuthOverBinaryProtocol
org.apache.pulsar.client.api.TlsProducerConsumerTest.testTlsClientAuthOverHTTPProtocol

The tests seems to be failed due to the change. Can you please take a look at those tests?

@wolfstudy
Copy link
Member Author

wolfstudy commented Dec 2, 2019

The tests seems to be failed due to the change. Can you please take a look at those tests?

Sure, will fix them.

@wolfstudy
fix ci error
4cde912 
Signed-off-by: xiaolong.ran <rxl@apache.org>
@wolfstudy wolfstudy force-pushed the xiaolong/reopen-5603 branch from 89c620d to 4cde912 Compare December 2, 2019 05:12
@wolfstudy
fix ci error
d583443 
Signed-off-by: xiaolong.ran <rxl@apache.org>
@wolfstudy
Copy link
Member Author

wolfstudy commented Dec 2, 2019

run cpp tests

1 similar comment
@wolfstudy
Copy link
Member Author

wolfstudy commented Dec 3, 2019

run cpp tests

@wolfstudy wolfstudy merged commit e121108 into apache:master Dec 3, 2019
@murong00 murong00 mentioned this pull request Dec 12, 2019
Merged
tuteng pushed a commit that referenced this pull request Jan 3, 2020
@murong00 @tuteng
[Reopen][Issue 5597] Retry when getPartitionedTopicMetadata failed (#…
c7094c9 
…5844)

Motivation
Fixes #5597

Add backoff retries when getting partitioned metadata from brokers.

The change in #5734 (copy from #5603) used the wrong time unit when inited Backoff which failed to trigger the retry logic as expected.

Modifications
Correct the time unit and add some useful log.
@merlimat merlimat mentioned this pull request Feb 28, 2020
Merged
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@murong00 @huangdx0726
[Reopen][Issue 5597] Retry when getPartitionedTopicMetadata failed (a…
4f3b44b 
…pache#5844)

Motivation
Fixes apache#5597

Add backoff retries when getting partitioned metadata from brokers.

The change in apache#5734 (copy from apache#5603) used the wrong time unit when inited Backoff which failed to trigger the retry logic as expected.

Modifications
Correct the time unit and add some useful log.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sijie sijie sijie approved these changes

@jiazhai jiazhai jiazhai approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@aahmed-se aahmed-se Awaiting requested review from aahmed-se

Assignees

@wolfstudy wolfstudy

Labels

area/client type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Projects

None yet

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

[pulsar-client-java] retry when getPartitionedTopicMetadata failed

4 participants

@wolfstudy @sijie @jiazhai @codelipenghui