Correct an invalid null check #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
* [Issue:45] Fix the logic of message router Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com> * add unit test case for TopicPartitions Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Mar 29, 2022
* [elasticsearch] support token based auth
nicoloboschi
referenced
this pull request
in nicoloboschi/pulsar
Apr 1, 2022
* [elasticsearch] support token based auth
nicoloboschi
referenced
this pull request
in nicoloboschi/pulsar
Apr 6, 2022
* [elasticsearch] support token based auth
nicoloboschi
referenced
this pull request
in nicoloboschi/pulsar
Apr 12, 2022
* [elasticsearch] support token based auth (cherry picked from commit cf13b39)
2 tasks
nodece
added a commit
to nodece/pulsar
that referenced
this pull request
Mar 25, 2025
…the GEO (apache#46) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
added a commit
to nodece/pulsar
that referenced
this pull request
Mar 27, 2025
…the GEO (apache#46) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The condition is simply wrong. It checks if serviceURL IS null, and then use it.
It causes NPE if serviceUrl is not specified in a config file.
Modifications
Correct the condition to check if the variable is blank.
Result
pulsar-client shows the usage without NPE.