Skip to content

access individualDeletedMessages with thread-safe while filtering out replay-message #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merlimat merged 1 commit into from
Sep 29, 2016
Merged

access individualDeletedMessages with thread-safe while filtering out replay-message #45

merlimat merged 1 commit into from
Sep 29, 2016

Conversation

@rdhabalia
Copy link
Contributor

@rdhabalia rdhabalia commented Sep 29, 2016

Motivation

Access of ManagedCursorImpl.individualDeletedMessages should be thread-safe. So, while filtering out replay-message, need to lock individualDeletedMessages while accessing it.

Modifications

add read lock while accessing individualDeletedMessages

Result

No functionality change.

@yahoocla
Copy link

yahoocla commented Sep 29, 2016

CLA is valid!

1 similar comment
@yahoocla
Copy link

yahoocla commented Sep 29, 2016

CLA is valid!

@rdhabalia rdhabalia added the type/bug The PR fixed a bug or issue reported a bug label Sep 29, 2016
@rdhabalia rdhabalia added this to the 1.15 milestone Sep 29, 2016
@rdhabalia rdhabalia self-assigned this Sep 29, 2016
@yahoocla
Copy link

yahoocla commented Sep 29, 2016

CLA is valid!

@rdhabalia rdhabalia mentioned this pull request Sep 29, 2016
Merged
merlimat
merlimat approved these changes Sep 29, 2016
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@merlimat merlimat merged commit 26671f6 into apache:master Sep 29, 2016
@rdhabalia rdhabalia deleted the replay-lock branch November 11, 2016 23:03
sijie pushed a commit to sijie/pulsar that referenced this pull request Mar 4, 2018
@srkukarni @sijie
Fileinterface (apache#45)
5ea8065 
* Create pulsar-functions module (#1)

* Create pulsar-functions module

* rename `sdk` package to `api`

* Added the first cut of the Java interface for Pulsar functions (#2)

* Adhere to rest semantics

* Convert create function to a post request
massakam pushed a commit to massakam/pulsar that referenced this pull request Aug 6, 2020
@hrsakai
Merge pull request apache#45 from massakam/introduce-license-check-an…
9bc6646 
…d-add

Introduce license-check-and-add module
hangc0276 pushed a commit to hangc0276/pulsar that referenced this pull request May 26, 2021
@jiazhai @sijie
Add ssl listeners and sslCtxRefresher in channelInitializer (apache#45)
3424abc 
Add ssl listeners and sslCtxRefresher in channelInitializer
@xiaotongwang1 xiaotongwang1 mentioned this pull request Aug 4, 2021
Closed
@ZHr-UChiHa ZHr-UChiHa mentioned this pull request Jun 3, 2023
Open
2 tasks
tisonkun added a commit to tisonkun/pulsar that referenced this pull request Jul 12, 2023
@tisonkun
[hotfix] Workaround new violations message (apache#45)
9e8ef1d 
Signed-off-by: tison <wander4096@gmail.com>
nodece added a commit to nodece/pulsar that referenced this pull request Mar 24, 2025
@nodece
[improve][broker] Ensure topic creation and partition update before s…
f878958 
…tarting GEO (apache#45)

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece added a commit to nodece/pulsar that referenced this pull request Mar 27, 2025
@nodece
[improve][broker] Ensure topic creation and partition update before s…
7b059be 
…tarting GEO (apache#45)

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merlimat merlimat merlimat approved these changes

Assignees

@rdhabalia rdhabalia

Labels

type/bug The PR fixed a bug or issue reported a bug

Projects

None yet

Milestone

1.15

Development

Successfully merging this pull request may close these issues.

3 participants

@rdhabalia @yahoocla @merlimat