-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][broker]Leaving orphan schemas and topic-level policies after partitioned topic is deleted by GC #24971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d topic was deleted by GC
lhotari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24971 +/- ##
=============================================
+ Coverage 38.56% 74.32% +35.76%
- Complexity 13262 33652 +20390
=============================================
Files 1856 1920 +64
Lines 145287 150082 +4795
Branches 16877 17405 +528
=============================================
+ Hits 56025 111549 +55524
+ Misses 81696 29661 -52035
- Partials 7566 8872 +1306
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…rtitioned topic is deleted by GC (apache#24971) (cherry picked from commit 27ce955) (cherry picked from commit d2560f3)
…rtitioned topic is deleted by GC (apache#24971) (cherry picked from commit 27ce955) (cherry picked from commit d2560f3)
Motivation
How to reproduce the issue
brokerDeleteInactiveTopicsEnabledandbrokerDeleteInactivePartitionedTopicMetadataEnabledcluster 1: deletes all partitionscluster 2: deletes all partitionscluster 1: deletes partitioned topic metadata(the schema and topic-level policies will also be deleted with the operation)cluster 2: since the partitioned topic metadata was deleted bycluster 1(both clusters share the same metadata), it deletes nothing, then the issue occurs: topics were deleted, but schemas and topic-level policies are still thereModifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x