Skip to content

Conversation

@poorbarcode
Copy link
Contributor

Motivation

How to reproduce the issue

  • Start two clusters with a global configuration metadata store
  • Enable brokerDeleteInactiveTopicsEnabled and brokerDeleteInactivePartitionedTopicMetadataEnabled
  • After topic partitions and topics are deleted from the GC mechanism, the following events occur
    • cluster 1: deletes all partitions
    • cluster 2: deletes all partitions
    • cluster 1: deletes partitioned topic metadata(the schema and topic-level policies will also be deleted with the operation)
    • cluster 2: since the partitioned topic metadata was deleted by cluster 1(both clusters share the same metadata), it deletes nothing, then the issue occurs: topics were deleted, but schemas and topic-level policies are still there

Modifications

  • fix the issue

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@poorbarcode poorbarcode added this to the 4.2.0 milestone Nov 11, 2025
@poorbarcode poorbarcode self-assigned this Nov 11, 2025
@poorbarcode poorbarcode added type/bug The PR fixed a bug or issue reported a bug ready-to-test release/4.1.2 release/4.0.8 labels Nov 11, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 11, 2025
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.32%. Comparing base (676ba07) to head (bfd82ee).
⚠️ Report is 29 commits behind head on master.

Files with missing lines Patch % Lines
...sar/broker/service/persistent/PersistentTopic.java 80.95% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #24971       +/-   ##
=============================================
+ Coverage     38.56%   74.32%   +35.76%     
- Complexity    13262    33652    +20390     
=============================================
  Files          1856     1920       +64     
  Lines        145287   150082     +4795     
  Branches      16877    17405      +528     
=============================================
+ Hits          56025   111549    +55524     
+ Misses        81696    29661    -52035     
- Partials       7566     8872     +1306     
Flag Coverage Δ
inttests 26.34% <9.52%> (+0.16%) ⬆️
systests 22.90% <9.52%> (+0.14%) ⬆️
unittests 73.85% <80.95%> (+39.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...sar/broker/service/persistent/PersistentTopic.java 79.22% <80.95%> (+27.73%) ⬆️

... and 1418 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari merged commit 27ce955 into apache:master Nov 11, 2025
100 of 103 checks passed
lhotari pushed a commit that referenced this pull request Nov 11, 2025
…rtitioned topic is deleted by GC (#24971)

(cherry picked from commit 27ce955)
lhotari pushed a commit that referenced this pull request Nov 11, 2025
…rtitioned topic is deleted by GC (#24971)

(cherry picked from commit 27ce955)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 13, 2025
…rtitioned topic is deleted by GC (apache#24971)

(cherry picked from commit 27ce955)
(cherry picked from commit d2560f3)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 14, 2025
…rtitioned topic is deleted by GC (apache#24971)

(cherry picked from commit 27ce955)
(cherry picked from commit d2560f3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants