[cleanup][broker][branch-3.0] Remove no-op configurations caused by cherry-picking #24960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metadata size–based threshold compression was introduced in [PIP-270](https://github.com/apache/pulsar/issues/20307), which isn’t included in `3.0.x`. Therefore, **these two configurations don’t have any effect** in the `3.0.x` branch: - managedCursorInfoCompressionThresholdInBytes - managedLedgerInfoCompressionThresholdInBytes
4 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR removes non-functional configuration properties for compression threshold settings from broker and standalone configuration files. The removed properties (managedCursorInfoCompressionThresholdInBytes and managedLedgerInfoCompressionThresholdInBytes) are not defined in the Java codebase and therefore have no effect.
Key changes:
- Removed duplicate/unused compression threshold configuration entries from configuration files
- Cleaned up configuration documentation by removing references to non-existent properties
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| conf/broker.conf | Removed two non-functional compression threshold configuration entries with documentation |
| conf/standalone.conf | Removed two non-functional compression threshold configuration entries with documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jiazhai
approved these changes
Nov 8, 2025
lhotari
approved these changes
Nov 8, 2025
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Nov 12, 2025
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 13, 2025
…herry-picking (apache#24960) (cherry picked from commit 81a9d0d)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 13, 2025
…herry-picking (apache#24960) (cherry picked from commit 81a9d0d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #24391 (comment)
These two configurations were cherry-picked from #24391. However, the metadata size–based threshold compression feature introduced in PIP-270 is not included in the
3.0.xbranch.Therefore, these two configurations don’t have any effect in the
3.0.xbranch and should be deleted to avoid confusing users.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: