Skip to content

Conversation

@Dream95
Copy link
Contributor

@Dream95 Dream95 commented Nov 7, 2025

Motivation

The same message is sent every time, the set size is always 1.

Modifications

Use different messageData for each message sent.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Due to rate limiting, some messages should be dropped at broker, so consumer receives fewer messages

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

…imit

Signed-off-by: Dream95 <zhou_8621@163.com>
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 7, 2025
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch @Dream95

@Dream95
Copy link
Contributor Author

Dream95 commented Nov 10, 2025

How to restart the CI?

@lhotari
Copy link
Member

lhotari commented Nov 10, 2025

How to restart the CI?

@Dream95 You can add a comment "/pulsarbot rerun-failure-checks" on the PR to trigger a re-run. Re-running is possible for 3 days since the cached build artifacts expire after that period.

@lhotari
Copy link
Member

lhotari commented Nov 10, 2025

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.35%. Comparing base (3aaf345) to head (e325217).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24957      +/-   ##
============================================
- Coverage     74.44%   74.35%   -0.09%     
- Complexity    33702    34017     +315     
============================================
  Files          1920     1920              
  Lines        150062   150062              
  Branches      17404    17404              
============================================
- Hits         111716   111585     -131     
- Misses        29498    29593      +95     
- Partials       8848     8884      +36     
Flag Coverage Δ
inttests 26.54% <ø> (-0.09%) ⬇️
systests 22.89% <ø> (-0.11%) ⬇️
unittests 73.89% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 85 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari merged commit 0896c0a into apache:master Nov 10, 2025
51 checks passed
lhotari pushed a commit that referenced this pull request Nov 11, 2025
…imit (#24957)

Signed-off-by: Dream95 <zhou_8621@163.com>
(cherry picked from commit 0896c0a)
lhotari pushed a commit that referenced this pull request Nov 11, 2025
…imit (#24957)

Signed-off-by: Dream95 <zhou_8621@163.com>
(cherry picked from commit 0896c0a)
lhotari pushed a commit that referenced this pull request Nov 11, 2025
…imit (#24957)

Signed-off-by: Dream95 <zhou_8621@163.com>
(cherry picked from commit 0896c0a)
nodece pushed a commit to nodece/pulsar that referenced this pull request Nov 12, 2025
…imit (apache#24957)

Signed-off-by: Dream95 <zhou_8621@163.com>
(cherry picked from commit 0896c0a)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 13, 2025
…imit (apache#24957)

Signed-off-by: Dream95 <zhou_8621@163.com>
(cherry picked from commit 0896c0a)
(cherry picked from commit 65320e7)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 13, 2025
…imit (apache#24957)

Signed-off-by: Dream95 <zhou_8621@163.com>
(cherry picked from commit 0896c0a)
(cherry picked from commit 65320e7)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 13, 2025
…imit (apache#24957)

Signed-off-by: Dream95 <zhou_8621@163.com>
(cherry picked from commit 0896c0a)
(cherry picked from commit 66b7f7c)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 14, 2025
…imit (apache#24957)

Signed-off-by: Dream95 <zhou_8621@163.com>
(cherry picked from commit 0896c0a)
(cherry picked from commit 66b7f7c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants