-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][test] Fix invalid test NonPersistentTopicTest.testProducerRateLimit #24957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…imit Signed-off-by: Dream95 <zhou_8621@163.com>
lhotari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lhotari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good catch @Dream95
|
How to restart the CI? |
@Dream95 You can add a comment "/pulsarbot rerun-failure-checks" on the PR to trigger a re-run. Re-running is possible for 3 days since the cached build artifacts expire after that period. |
|
/pulsarbot rerun-failure-checks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24957 +/- ##
============================================
- Coverage 74.44% 74.35% -0.09%
- Complexity 33702 34017 +315
============================================
Files 1920 1920
Lines 150062 150062
Branches 17404 17404
============================================
- Hits 111716 111585 -131
- Misses 29498 29593 +95
- Partials 8848 8884 +36
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…imit (apache#24957) Signed-off-by: Dream95 <zhou_8621@163.com> (cherry picked from commit 0896c0a)
…imit (apache#24957) Signed-off-by: Dream95 <zhou_8621@163.com> (cherry picked from commit 0896c0a) (cherry picked from commit 65320e7)
…imit (apache#24957) Signed-off-by: Dream95 <zhou_8621@163.com> (cherry picked from commit 0896c0a) (cherry picked from commit 65320e7)
…imit (apache#24957) Signed-off-by: Dream95 <zhou_8621@163.com> (cherry picked from commit 0896c0a) (cherry picked from commit 66b7f7c)
…imit (apache#24957) Signed-off-by: Dream95 <zhou_8621@163.com> (cherry picked from commit 0896c0a) (cherry picked from commit 66b7f7c)
Motivation
The same message is sent every time, the set size is always 1.
Modifications
Use different messageData for each message sent.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-complete