-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][broker] AvgShedder comparison error #24954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
approved these changes
Nov 6, 2025
Member
lhotari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24954 +/- ##
=========================================
Coverage 74.24% 74.24%
+ Complexity 33911 33892 -19
=========================================
Files 1913 1913
Lines 149510 149510
Branches 17373 17373
=========================================
+ Hits 110997 111008 +11
+ Misses 29685 29638 -47
- Partials 8828 8864 +36
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
lhotari
pushed a commit
that referenced
this pull request
Nov 11, 2025
Co-authored-by: dongzhonghua03 <dongzhonghua03@kuaishou.com> (cherry picked from commit 186b503)
lhotari
pushed a commit
that referenced
this pull request
Nov 11, 2025
Co-authored-by: dongzhonghua03 <dongzhonghua03@kuaishou.com> (cherry picked from commit 186b503)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-4.0
cherry-picked/branch-4.1
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/4.0.8
release/4.1.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
AvgShedder encounter Exception when sort broker by scores.
There is why:
Double value
o1.getValue() - o2.getValue()cast to int wil loss precision and break violation of transitivity.For example:
brokerScoreMap.put("X", 0.999);
brokerScoreMap.put("Y", 1.0);
brokerScoreMap.put("Z", 1.999);
(int)(0.999 - 1.0) = (int)(-0.001) = 0 → X == Y
(int)(1.0 - 1.999) = (int)(-0.999) = 0 → Y == Z
(int)(0.999 - 1.999) = (int)(-1.0) = -1 → X < Z
Modifications
Fix double cost to int. Use
Comparator.comparingDoubleDocumentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: