[fix][test] Fix flaky NonPersistentTopicTest.testProducerRateLimit #24951
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24951 +/- ##
=============================================
+ Coverage 38.77% 74.21% +35.43%
- Complexity 13380 33882 +20502
=============================================
Files 1856 1913 +57
Lines 145342 149505 +4163
Branches 16886 17372 +486
=============================================
+ Hits 56353 110948 +54595
+ Misses 81459 29699 -51760
- Partials 7530 8858 +1328
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Nov 12, 2025
…pache#24951) (cherry picked from commit 7c343d0)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 13, 2025
…pache#24951) (cherry picked from commit 7c343d0) (cherry picked from commit 997158b)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 13, 2025
…pache#24951) (cherry picked from commit 7c343d0) (cherry picked from commit 997158b)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 13, 2025
…pache#24951) (cherry picked from commit 7c343d0) (cherry picked from commit d4f0269)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 14, 2025
…pache#24951) (cherry picked from commit 7c343d0) (cherry picked from commit d4f0269)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24909
Motivation
The test uses 5 threads and produces 10 messages. It happens frequently that the test fails because the rate limit is not triggered.
Modifications
To increase the probability of triggering the rate limit, the number of threads is increased from 5 to 10, and the number of messages produced is increased from 10 to 500.
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: pdolif#18