[improve][broker] Don't log an error when updatePartitionedTopic is called on a non-partitioned topic #24943
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alled on a non-partitioned topic
lhotari
approved these changes
Nov 4, 2025
Technoboy-
approved these changes
Nov 4, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24943 +/- ##
=============================================
+ Coverage 38.56% 74.28% +35.71%
- Complexity 13262 33906 +20644
=============================================
Files 1856 1913 +57
Lines 145287 149450 +4163
Branches 16877 17363 +486
=============================================
+ Hits 56025 111013 +54988
+ Misses 81696 29590 -52106
- Partials 7566 8847 +1281
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
…alled on a non-partitioned topic (apache#24943) (cherry picked from commit e557b00) (cherry picked from commit c32dca9)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
…alled on a non-partitioned topic (apache#24943) (cherry picked from commit e557b00) (cherry picked from commit c32dca9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When a client attempts to update the number of partitions for a non-partitioned topic, the broker correctly rejects the request with a RestException.
However, it also logs this as an ERROR in the broker logs:
The error report here:
pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Lines 366 to 369 in 39bb675
For exceptions that are clearly caused by invalid parameters passed by the client, and which have already been clearly returned to the client, the broker should not log an ERROR.
Modifications
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: