Skip to content

[improve][broker] Optimize lookup result warn log #24942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dao-jun merged 1 commit into from
Nov 4, 2025
Merged

[improve][broker] Optimize lookup result warn log #24942

dao-jun merged 1 commit into from
Nov 4, 2025

Conversation

@shibd
Copy link
Member

@shibd shibd commented Nov 4, 2025 •
edited
Loading

Motivation

Whenever we use transactions, we find the broker is printing the following WARN log:

2025-11-03T14:37:19,206+0000 [pulsar-io-9-5] WARN  org.apache.pulsar.broker.lookup.TopicLookupBase - [persistent://pulsar/system/transaction_coordinator_assign-partition-11] Unexpected lookup result: brokerUrl is required when TLS isn't enabled. options: LookupOptions(authoritative=false, readOnly=false, loadTopicsInBundle=true, requestHttps=false, advertisedListenerName=gw, properties={}), result LookupData{brokerUrl=null, brokerUrlTls=pulsar+ssl://xxxx:6651, httpUrl=http://xxxx:8080/, httpUrlTls=null}

PR #23642 added a validation log for the internal lookup results of system topics by the broker client. However, for transaction_coordinator_assign, the user's client also performs a lookup.

pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/lookup/TopicLookupBase.java

Line 334 in 0214b97

boolean tlsEnabled = pulsar.getConfig().isBrokerClientTlsEnabled();

Because the check here uses the broker client's configuration to determine if TLS is enabled, it is not applicable for validating the lookup result from a user's client.

Modifications

  • Skip print warn log for topic:transaction_coordinator_assign

Verifying this change

  • verified on localhost.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@shibd shibd requested a review from poorbarcode November 4, 2025 09:44
@shibd shibd self-assigned this Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

@shibd Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Nov 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.31%. Comparing base (fefe771) to head (0214b97).
⚠️ Report is 23 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #24942       +/-   ##
=============================================
+ Coverage     38.46%   74.31%   +35.84%     
- Complexity    13239    33912    +20673     
=============================================
  Files          1856     1913       +57     
  Lines        145283   149449     +4166     
  Branches      16876    17363      +487     
=============================================
+ Hits          55890   111056    +55166     
+ Misses        81827    29537    -52290     
- Partials       7566     8856     +1290
Flag Coverage Δ
inttests 26.58% <100.00%> (+0.31%) ⬆️
systests 22.77% <33.33%> (+0.04%) ⬆️
unittests 73.83% <100.00%> (+39.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...g/apache/pulsar/broker/lookup/TopicLookupBase.java 70.46% <100.00%> (+14.67%) ⬆️

... and 1414 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dao-jun dao-jun merged commit 928cae2 into apache:master Nov 4, 2025
55 of 58 checks passed
shibd added a commit that referenced this pull request Nov 4, 2025
@shibd
[improve][broker] Optimize lookup result warn log (#24942)
a33f209 
(cherry picked from commit 928cae2)
shibd added a commit that referenced this pull request Nov 4, 2025
@shibd
[improve][broker] Optimize lookup result warn log (#24942)
3aa3301 
(cherry picked from commit 928cae2)
ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 6, 2025
@shibd @ganesh-ctds
[improve][broker] Optimize lookup result warn log (apache#24942)
1374302 
(cherry picked from commit 928cae2)
(cherry picked from commit a33f209)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 6, 2025
@shibd @srinath-ctds
[improve][broker] Optimize lookup result warn log (apache#24942)
b2ff7e6 
(cherry picked from commit 928cae2)
(cherry picked from commit a33f209)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dao-jun dao-jun dao-jun approved these changes

@poorbarcode poorbarcode poorbarcode approved these changes

Assignees

@shibd shibd

Labels

cherry-picked/branch-4.0 cherry-picked/branch-4.1 doc-not-needed Your PR changes do not impact docs ready-to-test release/4.0.8 release/4.1.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shibd @codecov-commenter @dao-jun @poorbarcode