[fix][broker] Fix bug in PersistentMessageExpiryMonitor which blocked further expirations #24941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… further expirations
4 tasks
poorbarcode
approved these changes
Nov 4, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24941 +/- ##
=============================================
+ Coverage 38.46% 74.22% +35.75%
- Complexity 13239 33509 +20270
=============================================
Files 1856 1913 +57
Lines 145283 149447 +4164
Branches 16876 17362 +486
=============================================
+ Hits 55890 110923 +55033
+ Misses 81827 29678 -52149
- Partials 7566 8846 +1280
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dao-jun
approved these changes
Nov 4, 2025
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
… further expirations (apache#24941) (cherry picked from commit 6cdd110) (cherry picked from commit 18bab37)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
… further expirations (apache#24941) (cherry picked from commit 6cdd110) (cherry picked from commit 18bab37)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#24881 introduced a bug that it would block further message expirations when mark delete position was at least once ahead of the position to expire.
Modifications
expirationCheckInProgress = FALSEbefore returning in the short-circuit caseDocumentation
docdoc-requireddoc-not-neededdoc-complete