[fix][broker] Fix stack overflow caused by race condition when closing a connection #24934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
lhotari
reviewed
Nov 3, 2025
...r/src/main/java/org/apache/pulsar/broker/service/AbstractDispatcherSingleActiveConsumer.java
Outdated
Show resolved
Hide resolved
lhotari
reviewed
Nov 3, 2025
...r/src/main/java/org/apache/pulsar/broker/service/AbstractDispatcherSingleActiveConsumer.java
Show resolved
Hide resolved
lhotari
reviewed
Nov 3, 2025
...r/src/main/java/org/apache/pulsar/broker/service/AbstractDispatcherSingleActiveConsumer.java
Outdated
Show resolved
Hide resolved
lhotari
reviewed
Nov 3, 2025
...r/src/main/java/org/apache/pulsar/broker/service/AbstractDispatcherSingleActiveConsumer.java
Outdated
Show resolved
Hide resolved
Member
|
/pulsarbot rerun-failure-checks |
dao-jun
approved these changes
Nov 3, 2025
Member
|
/pulsarbot rerun-failure-checks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24934 +/- ##
============================================
+ Coverage 74.28% 74.34% +0.06%
- Complexity 33886 33921 +35
============================================
Files 1913 1913
Lines 149425 149446 +21
Branches 17358 17362 +4
============================================
+ Hits 111001 111111 +110
+ Misses 29572 29501 -71
+ Partials 8852 8834 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
…g a connection (apache#24934) (cherry picked from commit 1dfe07e) (cherry picked from commit eeb51c4)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
…g a connection (apache#24934) (cherry picked from commit 1dfe07e) (cherry picked from commit eeb51c4)
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Nov 12, 2025
…g a connection (apache#24934) (cherry picked from commit 1dfe07e)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 13, 2025
…g a connection (apache#24934) (cherry picked from commit 1dfe07e) (cherry picked from commit e98e844)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 13, 2025
…g a connection (apache#24934) (cherry picked from commit 1dfe07e) (cherry picked from commit e98e844)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #24920 (comment)
Modifications
testOverrideInactiveConsumerto simulate the race condition by injecting a delay onchannelInactivevia the broker interceptor.addConsumerto wait forchannelInactiveis done. When the retry count reaches the limit, fail the methodDocumentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: