Skip to content

[fix][broker] Use poll instead remove to avoid NoSuchElementException #24933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Technoboy- merged 1 commit into from
Nov 3, 2025
Merged

[fix][broker] Use poll instead remove to avoid NoSuchElementException #24933

Technoboy- merged 1 commit into from
Nov 3, 2025

Conversation

@Technoboy-
Copy link
Contributor

@Technoboy- Technoboy- commented Nov 3, 2025

Motivation

Use poll instead of remove to avoid NoSuchElementException

2025-10-30T02:08:39,706+0000 [broker-client-shared-internal-executor-5-1] ERROR org.apache.pulsar.client.util.ExecutorProvider - Thread broker-client-shared-internal-executor-5-1 got uncaught Exception
java.util.NoSuchElementException: null
	at java.base/java.util.AbstractQueue.remove(Unknown Source) ~[?:?]
	at org.apache.pulsar.client.impl.RawReaderImpl$RawConsumerImpl.failPendingRawReceives(RawReaderImpl.java:221) 
	at org.apache.pulsar.client.impl.RawReaderImpl$RawConsumerImpl.lambda$failPendingReceive$0(RawReaderImpl.java:209) ~
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) ~[?:?]
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) ~[?:?]
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) 
	at java.base/java.lang.Thread.run(Unknown Source) [?:?]
2025-10-30T02:08:39,705+0000 [broker-client-shared-internal-executor-5-2] WARN  org.apache.pulsar.broker.service.persistent.PersistentTopic - [persistent://public/default/test] Compaction failure.
java.util.concurrent.CompletionException: java.util.concurrent.CancellationException
	at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(Unknown Source) ~[?:?]
	at java.base/java.util.concurrent.CompletableFuture.completeThrowable(Unknown Source) ~[?:?]
	at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source) ~[?:?]
	at java.base/java.util.concurrent.CompletableFuture.postComplete(Unknown Source) ~[?:?]
	at java.base/java.util.concurrent.CompletableFuture.cancel(Unknown Source) ~[?:?]
	at org.apache.pulsar.client.impl.RawReaderImpl$RawConsumerImpl.lambda$failPendingRawReceives$1(RawReaderImpl.java:223) 
	at java.base/java.util.ArrayList.forEach(Unknown Source) ~[?:?]
	at org.apache.pulsar.client.impl.RawReaderImpl$RawConsumerImpl.failPendingRawReceives(RawReaderImpl.java:223) 
	at org.apache.pulsar.client.impl.RawReaderImpl$RawConsumerImpl.reset(RawReaderImpl.java:234)

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Technoboy- Technoboy- self-assigned this Nov 3, 2025
@Technoboy- Technoboy- added this to the 4.2.0 milestone Nov 3, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.26%. Comparing base (fbc50b0) to head (2801def).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24933      +/-   ##
============================================
- Coverage     74.34%   74.26%   -0.09%     
- Complexity    33532    33868     +336     
============================================
  Files          1913     1913              
  Lines        149419   149422       +3     
  Branches      17356    17357       +1     
============================================
- Hits         111089   110968     -121     
- Misses        29480    29587     +107     
- Partials       8850     8867      +17
Flag Coverage Δ
inttests 26.22% <0.00%> (-0.49%) ⬇️
systests 22.72% <0.00%> (-0.13%) ⬇️
unittests 73.80% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...a/org/apache/pulsar/client/impl/RawReaderImpl.java 85.83% <100.00%> (-0.50%) ⬇️

... and 92 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Technoboy- Technoboy- merged commit 402ed5b into apache:master Nov 3, 2025
54 of 56 checks passed
lhotari pushed a commit that referenced this pull request Nov 4, 2025
@Technoboy- @lhotari
[fix][broker] Use poll instead remove to avoid `NoSuchElementExce…
d1d97b7 
…ption` (#24933)

(cherry picked from commit 402ed5b)
lhotari pushed a commit that referenced this pull request Nov 4, 2025
@Technoboy- @lhotari
[fix][broker] Use poll instead remove to avoid `NoSuchElementExce…
db676b9 
…ption` (#24933)

(cherry picked from commit 402ed5b)
ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 6, 2025
@Technoboy- @ganesh-ctds
[fix][broker] Use poll instead remove to avoid `NoSuchElementExce…
42e5f91 
…ption` (apache#24933)

(cherry picked from commit 402ed5b)
(cherry picked from commit db676b9)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 6, 2025
@Technoboy- @srinath-ctds
[fix][broker] Use poll instead remove to avoid `NoSuchElementExce…
fb87033 
…ption` (apache#24933)

(cherry picked from commit 402ed5b)
(cherry picked from commit db676b9)
lhotari pushed a commit that referenced this pull request Nov 17, 2025
@Technoboy- @lhotari
[fix][broker] Use poll instead remove to avoid `NoSuchElementExce…
ccbb433 
…ption` (#24933)

(cherry picked from commit 402ed5b)
lhotari pushed a commit that referenced this pull request Nov 17, 2025
@Technoboy- @lhotari
[fix][broker] Use poll instead remove to avoid `NoSuchElementExce…
807e261 
…ption` (#24933)

(cherry picked from commit 402ed5b)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Dec 2, 2025
@Technoboy- @manas-ctds
[fix][broker] Use poll instead remove to avoid `NoSuchElementExce…
fe488ce 
…ption` (apache#24933)

(cherry picked from commit 402ed5b)
(cherry picked from commit 807e261)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Dec 2, 2025
@Technoboy- @srinath-ctds
[fix][broker] Use poll instead remove to avoid `NoSuchElementExce…
9dca697 
…ption` (apache#24933)

(cherry picked from commit 402ed5b)
(cherry picked from commit 807e261)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Dec 3, 2025
@Technoboy- @nodece
[fix][broker] Use poll instead remove to avoid `NoSuchElementExce…
4fb7e82 
…ption` (apache#24933)

(cherry picked from commit 402ed5b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhotari lhotari lhotari approved these changes

@BewareMyPower BewareMyPower BewareMyPower approved these changes

Assignees

@Technoboy- Technoboy-

Labels

cherry-picked/branch-3.0 cherry-picked/branch-3.3 cherry-picked/branch-4.0 cherry-picked/branch-4.1 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.16 release/3.3.10 release/4.0.8 release/4.1.2

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Technoboy- @codecov-commenter @lhotari @BewareMyPower