[fix][broker] ExtensibleLoadManager: handle SessionReestablished and Reconnected events to re-register broker metadata #24932
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sionRebuild (apache#24907) Signed-off-by: Dream95 <zhou_8621@163.com>
lhotari
approved these changes
Nov 3, 2025
Member
lhotari
left a comment
There was a problem hiding this comment.
LGTM. Good catch @Dream95! This looks like a production code bug in Extensible LoadManager's BrokerRegistryImpl since it didn't register to handle the reconnection event. For that reason, I think it's worth changing the title of the PR to describe this.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24932 +/- ##
============================================
- Coverage 74.34% 74.24% -0.11%
- Complexity 33532 33880 +348
============================================
Files 1913 1913
Lines 149419 149427 +8
Branches 17356 17358 +2
============================================
- Hits 111089 110941 -148
- Misses 29480 29633 +153
- Partials 8850 8853 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
|
Great catch! Can we backport this to 3.3, 4.0, and 4.1? |
Contributor
|
note: when the broker registry migrated to the metadata cache from the lock manager, this session handler logic was not captured. ref: #23298 |
Member
Member
|
Not needed for branch-3.0 since #23298 isn't applied to that branch. |
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
…Reconnected events to re-register broker metadata (apache#24932) Signed-off-by: Dream95 <zhou_8621@163.com> (cherry picked from commit 95c1dab) (cherry picked from commit 4df635a)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
…Reconnected events to re-register broker metadata (apache#24932) Signed-off-by: Dream95 <zhou_8621@163.com> (cherry picked from commit 95c1dab) (cherry picked from commit 4df635a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24907
Motivation
The test code has an incorrect variable name,and re-registration will not happen until the ExtensibleLoadManagerImpl.monitorTask execute.
Modifications
Add re-register when session reestablished.
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: Dream95#2