[fix]Fixed getChildren('/') on Oxia based provider #24863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
approved these changes
Oct 17, 2025
dao-jun
approved these changes
Oct 17, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24863 +/- ##
=============================================
+ Coverage 38.49% 74.22% +35.72%
- Complexity 13160 33827 +20667
=============================================
Files 1856 1913 +57
Lines 145149 149315 +4166
Branches 16844 17331 +487
=============================================
+ Hits 55880 110830 +54950
+ Misses 81652 29645 -52007
- Partials 7617 8840 +1223
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
merlimat
added a commit
that referenced
this pull request
Oct 17, 2025
merlimat
added a commit
that referenced
this pull request
Oct 17, 2025
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 23, 2025
(cherry picked from commit 4ec4c8b)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
(cherry picked from commit 4ec4c8b)
lhotari
pushed a commit
that referenced
this pull request
Nov 17, 2025
(cherry picked from commit e656065)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
store.getChildren()was wrong if the requested key already ended with a/The existing tests (common to all providers) were not actually asserting correctly. it was always passing.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: