-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][test] Stabilize SequenceIdWithErrorTest by fencing after first publish to avoid empty-ledger deletion and send timeout #24861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lhotari
merged 1 commit into
apache:master
from
Denovo1998:fix_SequenceIdWithErrorTest_testCheckSequenceId
Oct 17, 2025
Merged
+10
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…publish to avoid empty-ledger deletion and send timeout
lhotari
approved these changes
Oct 17, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24861 +/- ##
============================================
- Coverage 74.45% 74.29% -0.16%
- Complexity 33531 33848 +317
============================================
Files 1913 1913
Lines 149280 149312 +32
Branches 17324 17330 +6
============================================
- Hits 111140 110933 -207
- Misses 29341 29550 +209
- Partials 8799 8829 +30
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Technoboy-
pushed a commit
that referenced
this pull request
Oct 23, 2025
…publish to avoid empty-ledger deletion and send timeout (#24861)
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 23, 2025
…publish to avoid empty-ledger deletion and send timeout (apache#24861) (cherry picked from commit 9ebf5fa)
Technoboy-
pushed a commit
that referenced
this pull request
Oct 27, 2025
…publish to avoid empty-ledger deletion and send timeout (#24861)
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 29, 2025
…publish to avoid empty-ledger deletion and send timeout (apache#24861) (cherry picked from commit b0ce575) (cherry picked from commit fe84bdb)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 30, 2025
…publish to avoid empty-ledger deletion and send timeout (apache#24861) (cherry picked from commit b0ce575) (cherry picked from commit fe84bdb)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Oct 30, 2025
…publish to avoid empty-ledger deletion and send timeout (apache#24861) (cherry picked from commit b0ce575)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
…publish to avoid empty-ledger deletion and send timeout (apache#24861) (cherry picked from commit 9ebf5fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-4.0
cherry-picked/branch-4.1
doc-not-needed
Your PR changes do not impact docs
release/3.0.15
release/4.0.8
release/4.1.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24849
Motivation
Detailed log as follows: https://gist.github.com/Denovo1998/0707fff19079a6694e4f7edbceddc10a
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: Denovo1998#12