[fix][test] Fix flaky LookupPropertiesTest.testConcurrentLookupProperties #24854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
Oct 14, 2025
lhotari
approved these changes
Oct 14, 2025
Member
lhotari
left a comment
There was a problem hiding this comment.
Great analysis. Thanks for fixing!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24854 +/- ##
============================================
- Coverage 74.36% 74.32% -0.04%
+ Complexity 33856 33481 -375
============================================
Files 1913 1913
Lines 149280 149280
Branches 17324 17324
============================================
- Hits 111012 110957 -55
- Misses 29445 29490 +45
- Partials 8823 8833 +10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 29, 2025
…ties (apache#24854) (cherry picked from commit d743278) (cherry picked from commit 324fadd)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
…ties (apache#24854) (cherry picked from commit d743278) (cherry picked from commit 324fadd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24837
Motivation
The test is flaky. It verifies that lookup requests use the lookup properties configured at the time when the request is triggered (and not at the time it is executed).
Therefore, it triggers 10 broker lookups in sequence and changes the lookup properties before each. The property "broker.id" is set to "key-0", "key-1",..., "key-9" respectively. To verify that the correct properties are used, the test uses the
BrokerIdAwareLoadManager, which extendsExtensibleLoadManagerImpl. It stores aCLIENT_ID_LIST. Whenassign()is called, the "broker.id" property is added to theCLIENT_ID_LIST.The test waits until all lookup requests finish, and then asserts that
CLIENT_ID_LISTis equal to "key-0", "key-1",..., "key-9". The assertion fails if the list contains the values in a different order.When running the tests, I noticed that the order is either "key-0", "key-1",..., "key-9" (ascending) or the reverse order. The reason seems to be related to CompletableFuture "callbacks" like
thenCompose()and their execution order. For example, for each of the 10 lookup requests,NamespaceService.getBrokerServiceUrlAsync()is called (in sequence), which contains the following code:pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java
Lines 225 to 226 in 461ffd8
When
thenCompose()is called, it can either be that thegetBundleAsync(topic)CompletableFuture is completed or not. If it is completed,thenCompose()can be executed immediately for each of the 10 lookup requests. The test passes. If it is not completed,thenCompose()is called 10 times but not executed immediately. It seems like the "callbacks" are stacked. Once the CompletableFuture completes, the 10 "callbacks" are executed in LIFO order, i.e., the one for "key-9" is executed first. Therefore, the order inCLIENT_ID_LISTwill be reversed, and the test fails.Modifications
Make the assertion less strict and ignore the value order.
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: pdolif#17