Skip to content

[fix][ml] Fix getNumberOfEntries may point to deleted ledger #24852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Technoboy- merged 3 commits into from
Oct 17, 2025
Merged

[fix][ml] Fix getNumberOfEntries may point to deleted ledger #24852

Technoboy- merged 3 commits into from
Oct 17, 2025

Conversation

@Technoboy-
Copy link
Contributor

@Technoboy- Technoboy- commented Oct 14, 2025 •
edited
Loading

Motivation

When we call getNumOfEntries, it count the number of entries without checking whether the ledger has been deleted, so numberOfEntriesSinceFirstNotAckedMessage may show there is 1 entry, but all the message has been acked. See the below stats.

{
  "waitingCursorsCount": 1,
  "pendingAddEntriesCount": 0,
  "entriesAddedCounter": 5820,
  "numberOfEntries": 0,
  "totalSize": 0,
  "currentLedgerEntries": 0,
  "currentLedgerSize": 0,
  "lastLedgerCreatedTimestamp": "2025-10-09T06:00:25.57Z",
  "lastLedgerCreationFailureTimestamp": "",
  "lastConfirmedEntry": "10461995:143",
  "state": "LedgerOpened",
  "ledgers": [
    {
      "ledgerId": 10469839,
      "entries": 0,
      "size": 0,
      "timestamp": 0,
      "offloaded": false,
      "metadata": "",
      "underReplicated": false
    }
  ],
  "cursors": {
    "test-service": {
      "markDeletePosition": "10461995:143",
      "readPosition": "10461995:144",
      "waitingReadOp": true,
      "pendingReadOps": 0,
      "messagesConsumedCounter": 5820,
      "cursorLedger": 10462118,
      "cursorLedgerLastEntry": 200,
      "individuallyDeletedMessages": "[]",
      "lastLedgerWitchTimestamp": "",
      "state": "Open",
      "numberOfEntriesSinceFirstNotAckedMessage": 1,
    }
  },
}

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Technoboy- Technoboy- self-assigned this Oct 14, 2025
@Technoboy- Technoboy- added this to the 4.2.0 milestone Oct 14, 2025
@github-actions
Copy link

github-actions bot commented Oct 14, 2025

@Technoboy- Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Oct 14, 2025
@Technoboy- Technoboy- requested a review from coderzc October 14, 2025 12:26
@Technoboy- Technoboy- merged commit c9b734b into apache:master Oct 17, 2025
141 of 145 checks passed
Technoboy- added a commit that referenced this pull request Oct 17, 2025
@Technoboy-
[fix][ml] Fix getNumberOfEntries may point to deleted ledger (#24852)
d87f712
Technoboy- added a commit that referenced this pull request Oct 17, 2025
@Technoboy-
[fix][ml] Fix getNumberOfEntries may point to deleted ledger (#24852)
a85a064
Technoboy- added a commit that referenced this pull request Oct 17, 2025
@Technoboy-
[fix][ml] Fix getNumberOfEntries may point to deleted ledger (#24852)
46bd835
Technoboy- added a commit that referenced this pull request Oct 17, 2025
@Technoboy-
[fix][ml] Fix getNumberOfEntries may point to deleted ledger (#24852)
c969b02
Technoboy- added a commit that referenced this pull request Oct 23, 2025
@Technoboy-
Fix compile issue by cherry-picked #24852
2afdc9d
ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Oct 23, 2025
@Technoboy- @ganesh-ctds
[fix][ml] Fix getNumberOfEntries may point to deleted ledger (apach…
1948bd5 
…e#24852)

(cherry picked from commit a85a064)
ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Oct 23, 2025
@Technoboy- @ganesh-ctds
Fix compile issue by cherry-picked apache#24852
bc46abf 
(cherry picked from commit 2afdc9d)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Oct 28, 2025
@Technoboy- @manas-ctds
[fix][ml] Fix getNumberOfEntries may point to deleted ledger (apach…
e49eb1d 
…e#24852)

(cherry picked from commit c969b02)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Oct 30, 2025
@Technoboy- @srinath-ctds
[fix][ml] Fix getNumberOfEntries may point to deleted ledger (apach…
9b01ed8 
…e#24852)

(cherry picked from commit c969b02)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Oct 30, 2025
@Technoboy- @nodece
[fix][ml] Fix getNumberOfEntries may point to deleted ledger (apach…
0e9f0e3 
…e#24852)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 6, 2025
@Technoboy- @srinath-ctds
[fix][ml] Fix getNumberOfEntries may point to deleted ledger (apach…
9c83d13 
…e#24852)

(cherry picked from commit a85a064)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 6, 2025
@Technoboy- @srinath-ctds
Fix compile issue by cherry-picked apache#24852
97368ed 
(cherry picked from commit 2afdc9d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@poorbarcode poorbarcode poorbarcode approved these changes

@coderzc coderzc coderzc approved these changes

Assignees

@Technoboy- Technoboy-

Labels

cherry-picked/branch-3.0 cherry-picked/branch-3.3 cherry-picked/branch-4.0 cherry-picked/branch-4.1 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.15 release/3.3.10 release/4.0.8 release/4.1.2

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Technoboy- @codelipenghui @poorbarcode @coderzc @lhotari