Skip to content

[improve][client]Add null check for Pulsar client clock configuration #24848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Technoboy- merged 1 commit into from
Oct 27, 2025
Merged

[improve][client]Add null check for Pulsar client clock configuration #24848

Technoboy- merged 1 commit into from
Oct 27, 2025

Conversation

@3pacccccc
Copy link
Contributor

@3pacccccc 3pacccccc commented Oct 14, 2025

Motivation

Currently, when setting a clock for the Pulsar client, there is no null check for the clock parameter. This can cause a NullPointerException when sending messages if a null clock is passed.1

Modifications

This PR adds a null check for the clock parameter to provide a clear error message and prevent NPEs.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: 3pacccccc#26

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 14, 2025
@3pacccccc
Copy link
Contributor Author

3pacccccc commented Oct 14, 2025

BTW, For custom clock implementations, if the millis() method returns abnormal data (such as negative numbers(eg. -1), extremely large values(eg. 9999999999)) or throws exceptions directly, these cases are not validated. Such validations should be considered? any suggestions?

@lhotari lhotari added this to the 4.2.0 milestone Oct 14, 2025
@Technoboy- Technoboy- closed this Oct 27, 2025
@Technoboy- Technoboy- reopened this Oct 27, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.02%. Comparing base (461ffd8) to head (751a34f).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24848      +/-   ##
============================================
- Coverage     74.36%   74.02%   -0.34%     
+ Complexity    33856    32641    -1215     
============================================
  Files          1913     1913              
  Lines        149280   152228    +2948     
  Branches      17324    18163     +839     
============================================
+ Hits         111012   112690    +1678     
- Misses        29445    30515    +1070     
- Partials       8823     9023     +200
Flag Coverage Δ
inttests 27.27% <0.00%> (+0.62%) ⬆️
systests 23.24% <0.00%> (+0.38%) ⬆️
unittests 73.41% <100.00%> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...g/apache/pulsar/client/impl/ClientBuilderImpl.java 87.02% <100.00%> (+0.07%) ⬆️

... and 92 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Technoboy- Technoboy- merged commit 54db7f2 into apache:master Oct 27, 2025
280 of 294 checks passed
lhotari pushed a commit that referenced this pull request Oct 28, 2025
@3pacccccc @lhotari
[improve][client]Add null check for Pulsar client clock configuration (…
fb1b2a5 
…#24848)

(cherry picked from commit 54db7f2)
lhotari pushed a commit that referenced this pull request Oct 28, 2025
@3pacccccc @lhotari
[improve][client]Add null check for Pulsar client clock configuration (…
936b240 
…#24848)

(cherry picked from commit 54db7f2)
lhotari pushed a commit that referenced this pull request Oct 28, 2025
@3pacccccc @lhotari
[improve][client]Add null check for Pulsar client clock configuration (…
79784c0 
…#24848)

(cherry picked from commit 54db7f2)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Oct 29, 2025
@3pacccccc @manas-ctds
[improve][client]Add null check for Pulsar client clock configuration (…
63c008b 
…apache#24848)

(cherry picked from commit 54db7f2)
(cherry picked from commit fb1b2a5)
priyanshu-ctds pushed a commit to datastax/pulsar that referenced this pull request Oct 29, 2025
@3pacccccc @priyanshu-ctds
[improve][client]Add null check for Pulsar client clock configuration (…
62936e5 
…apache#24848)

(cherry picked from commit 54db7f2)
(cherry picked from commit 79784c0)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Oct 30, 2025
@3pacccccc @srinath-ctds
[improve][client]Add null check for Pulsar client clock configuration (…
f11f7e3 
…apache#24848)

(cherry picked from commit 54db7f2)
(cherry picked from commit 79784c0)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Oct 30, 2025
@3pacccccc @nodece
[improve][client]Add null check for Pulsar client clock configuration (…
b8fccaf 
…apache#24848)

(cherry picked from commit 54db7f2)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 6, 2025
@3pacccccc @srinath-ctds
[improve][client]Add null check for Pulsar client clock configuration (…
61c2480 
…apache#24848)

(cherry picked from commit 54db7f2)
(cherry picked from commit fb1b2a5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhotari lhotari lhotari approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

@dao-jun dao-jun dao-jun approved these changes

Assignees

@3pacccccc 3pacccccc

Labels

cherry-picked/branch-3.0 cherry-picked/branch-4.0 cherry-picked/branch-4.1 doc-not-needed Your PR changes do not impact docs release/3.0.15 release/4.0.8 release/4.1.2

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@3pacccccc @codecov-commenter @lhotari @Technoboy- @dao-jun