[fix] Fix mixed lookup/partition metadata requests causing reliability issues and incorrect responses #24832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
approved these changes
Oct 9, 2025
pulsar-common/src/main/java/org/apache/pulsar/common/protocol/PulsarDecoder.java
Show resolved
Hide resolved
ad79165 to
b66dee8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24832 +/- ##
=============================================
+ Coverage 30.69% 74.24% +43.55%
- Complexity 51 33787 +33736
=============================================
Files 1854 1913 +59
Lines 144987 149178 +4191
Branches 16818 17304 +486
=============================================
+ Hits 44502 110760 +66258
+ Misses 93567 29584 -63983
- Partials 6918 8834 +1916
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
nodece
approved these changes
Oct 9, 2025
Member
nodece
left a comment
There was a problem hiding this comment.
LGTM
Although part of the issue has been addressed, I'm still concerned that asynchronous handling may lead to accessing variables after cmd have been cleared (for example, in the interceptor).
BewareMyPower
previously approved these changes
Oct 9, 2025
Contributor
Do you mean BTW, I checked the code in Pulsar that |
Member
|
Deep copy is a good idea. |
2 tasks
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 15, 2025
…y issues and incorrect responses (apache#24832) (cherry picked from commit 4457b08) (cherry picked from commit 4600efe)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 15, 2025
…y issues and incorrect responses (apache#24832) (cherry picked from commit 4457b08) (cherry picked from commit 5c4ee53)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 30, 2025
…y issues and incorrect responses (apache#24832) (cherry picked from commit 4457b08) (cherry picked from commit 4600efe)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Oct 30, 2025
…y issues and incorrect responses (apache#24832) (cherry picked from commit 4457b08)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
…y issues and incorrect responses (apache#24832) (cherry picked from commit 4457b08) (cherry picked from commit 5c4ee53)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PulsarDecoder unnecessarily keeps a reference to the last parsed message. It's better to clear it immediately to avoid unnecessary memory growth when there are multiple connections.
This mainly impacts
GET_TOPICS_OF_NAMESPACE_RESPONSEwhich can be large.While making this change, it was noticed that this revealed a major reliability issue in Pulsar. Lookup requests and Partition metadata requests were getting reused and potentially mixed up in cases where there would be multiple concurrent lookup requests in progress on the same connection. The impact of this has been that lookup or partition metadata requests have failed and also that they have returned incorrect information.
The problem in these cases has been a violation of the rule documented in #18998. The implementations of
handle*methods shouldn't keep references to the command after the method returns. When the command is handle asynchronously, a copy is usually needed if the asynchronous handler makes a reference to the command.Modifications
cmd.clear()in the finally block ofchannelRead.handleLookup,handlePartitionMetadataRequestandhandleCommandWatchTopicListDocumentation
docdoc-requireddoc-not-neededdoc-complete