[fix][client] Fix getPendingQueueSize for PartitionedTopicProducerStatsRecorderImpl: avoid NPE and implement aggregation #24830
+34
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dTopicProducerStatsRecorderImpl
60d21b7 to
1c1ae9c
Compare
codelipenghui
approved these changes
Oct 8, 2025
nodece
reviewed
Oct 9, 2025
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerStatsRecorderImpl.java
Outdated
Show resolved
Hide resolved
dao-jun
approved these changes
Oct 9, 2025
Co-authored-by: Zixuan Liu <nodeces@gmail.com>
…-with-partitioned-topic-stats
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24830 +/- ##
=============================================
+ Coverage 38.39% 74.22% +35.83%
- Complexity 13123 33405 +20282
=============================================
Files 1856 1913 +57
Lines 145015 149181 +4166
Branches 16818 17304 +486
=============================================
+ Hits 55684 110737 +55053
+ Misses 81787 29607 -52180
- Partials 7544 8837 +1293
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 15, 2025
…tsRecorderImpl: avoid NPE and implement aggregation (apache#24830) Co-authored-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit a43762b) (cherry picked from commit f758244)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 15, 2025
…tsRecorderImpl: avoid NPE and implement aggregation (apache#24830) Co-authored-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit a43762b) (cherry picked from commit 18323a9)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 30, 2025
…tsRecorderImpl: avoid NPE and implement aggregation (apache#24830) Co-authored-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit a43762b) (cherry picked from commit f758244)
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
Oct 30, 2025
…tsRecorderImpl: avoid NPE and implement aggregation (apache#24830) Co-authored-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit a43762b)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
…tsRecorderImpl: avoid NPE and implement aggregation (apache#24830) Co-authored-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit a43762b) (cherry picked from commit 18323a9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When getPendingQueueSize is called for stats returned from a multi-topics producer, it will result in NPE
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete