[fix][build] Fix maven deploy with maven-source-plugin 3.3.1 #24811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24811 +/- ##
============================================
- Coverage 74.44% 74.27% -0.18%
+ Complexity 33859 33422 -437
============================================
Files 1912 1912
Lines 149072 149072
Branches 17299 17299
============================================
- Hits 110981 110719 -262
- Misses 29292 29520 +228
- Partials 8799 8833 +34
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
nodece
approved these changes
Oct 2, 2025
LucasEby
pushed a commit
to LucasEby/pulsar
that referenced
this pull request
Oct 3, 2025
lhotari
added a commit
that referenced
this pull request
Oct 4, 2025
(cherry picked from commit f5547dc)
lhotari
added a commit
that referenced
this pull request
Oct 4, 2025
(cherry picked from commit f5547dc)
lhotari
added a commit
that referenced
this pull request
Oct 4, 2025
(cherry picked from commit f5547dc)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 15, 2025
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Apache Parent POM was updated from version 29 to 35 in PR #24742. It upgraded
maven-source-pluginfrom version3.2.1to3.3.1. That brokemvn deploywith this type of error message:Modifications
Set
attach-sourcesphase tononeformaven-source-pluginwhenmaven-shade-pluginhas been configured with<createSourcesJar>true</createSourcesJar>. This currently applies topulsar-client-allmodule.Documentation
docdoc-requireddoc-not-neededdoc-complete