[improve][broker]Improve NamespaceService log that is printed when cluster was removed #24801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
approved these changes
Sep 29, 2025
codelipenghui
approved these changes
Sep 29, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24801 +/- ##
=============================================
+ Coverage 38.67% 74.22% +35.55%
- Complexity 13237 33378 +20141
=============================================
Files 1850 1911 +61
Lines 144540 149033 +4493
Branches 16763 17294 +531
=============================================
+ Hits 55895 110621 +54726
+ Misses 81156 29579 -51577
- Partials 7489 8833 +1344
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
RobertIndie
approved these changes
Sep 30, 2025
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…uster was removed (apache#24801)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 15, 2025
…uster was removed (apache#24801) (cherry picked from commit 771ce41) (cherry picked from commit c111de1)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
…uster was removed (apache#24801) (cherry picked from commit 771ce41) (cherry picked from commit c111de1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
namespaceBundle.toString()already contains thenamespace.toString(), the format{ns}-{ns-bundle}will print a namespace like{tenant}/{ns}-{tenant}/{ns}/{bundle}, which makes concerning that leads to users assume it is av1namespace.Modifications
Improve the log.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x