[fix][client] Fix thread leak in reloadLookUp method which is used by ServiceUrlProvider #24794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ServiceUrlProvider
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24794 +/- ##
=============================================
+ Coverage 36.09% 74.25% +38.15%
- Complexity 13111 33502 +20391
=============================================
Files 1856 1913 +57
Lines 145250 149419 +4169
Branches 16869 17356 +487
=============================================
+ Hits 52430 110948 +58518
+ Misses 85543 29605 -55938
- Partials 7277 8866 +1589
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
nodece
reviewed
Sep 28, 2025
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
Outdated
Show resolved
Hide resolved
nodece
approved these changes
Oct 31, 2025
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 3, 2025
… ServiceUrlProvider (apache#24794) (cherry picked from commit fbc50b0) (cherry picked from commit 90ef442)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 3, 2025
… ServiceUrlProvider (apache#24794) (cherry picked from commit fbc50b0) (cherry picked from commit cda1ddf)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 4, 2025
… ServiceUrlProvider (apache#24794) (cherry picked from commit fbc50b0) (cherry picked from commit cda1ddf)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
… ServiceUrlProvider (apache#24794) (cherry picked from commit fbc50b0) (cherry picked from commit 90ef442)
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Nov 12, 2025
… ServiceUrlProvider (apache#24794) (cherry picked from commit fbc50b0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
LookupService is replaced by calling reloadLookUp. However the previous instance is not closed. This causes a thread leak.
Modifications
Call the close method on the previous lookup after replacing LookupService.
Documentation
docdoc-requireddoc-not-neededdoc-complete