[improve][broker] Add tests for using absolute FQDN for advertisedAddress and remove extra dot from brokerId #24787
+101
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dao-jun
approved these changes
Sep 28, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24787 +/- ##
=============================================
+ Coverage 38.56% 74.28% +35.72%
- Complexity 13262 33908 +20646
=============================================
Files 1856 1913 +57
Lines 145287 149502 +4215
Branches 16877 17371 +494
=============================================
+ Hits 56025 111065 +55040
+ Misses 81696 29552 -52144
- Partials 7566 8885 +1319
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
…ress and remove extra dot from brokerId (apache#24787) (cherry picked from commit a1ed5c4) (cherry picked from commit a3d9c53)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2025
…ress and remove extra dot from brokerId (apache#24787) (cherry picked from commit a1ed5c4) (cherry picked from commit a3d9c53)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When brokers are exposed directly to clients, there might be a need to make the
advertisedAddressabsolute so that clients with unoptimal ndots configuration won't do unnecessary DNS lookups on the client side when anadvertisedAddresswith less dots than ndots is returned to the client from topic lookup.Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete