[fix][misc] Fix compareTo contract violation for NamespaceBundleStats, TimeAverageMessageData and ResourceUnitRanking #24772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sageData - JVM's default sorting algorithm "TimSort" will fail with exception if compareTo doesn't meet the contract of Comparable.compareTo interface
…atifying the contract
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24772 +/- ##
=============================================
+ Coverage 39.04% 74.23% +35.18%
- Complexity 13345 33248 +19903
=============================================
Files 1844 1902 +58
Lines 144311 148392 +4081
Branches 16730 17201 +471
=============================================
+ Hits 56353 110158 +53805
+ Misses 80460 29444 -51016
- Partials 7498 8790 +1292
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
merlimat
approved these changes
Sep 22, 2025
merlimat
pushed a commit
that referenced
this pull request
Sep 22, 2025
…, TimeAverageMessageData and ResourceUnitRanking (#24772)
merlimat
pushed a commit
that referenced
this pull request
Sep 22, 2025
…, TimeAverageMessageData and ResourceUnitRanking (#24772)
Member
Author
|
After merging, I noticed that NamespaceBundleStats uses a slightly different implementation for |
15 tasks
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 26, 2025
…, TimeAverageMessageData and ResourceUnitRanking (apache#24772) (cherry picked from commit 7504538) (cherry picked from commit ae9be46)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 26, 2025
…, TimeAverageMessageData and ResourceUnitRanking (apache#24772) (cherry picked from commit 7504538) (cherry picked from commit ae9be46)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 29, 2025
…, TimeAverageMessageData and ResourceUnitRanking (apache#24772) (cherry picked from commit d6b00f9)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 29, 2025
…, TimeAverageMessageData and ResourceUnitRanking (apache#24772) (cherry picked from commit d6b00f9)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…, TimeAverageMessageData and ResourceUnitRanking (apache#24772)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Oct 30, 2025
…, TimeAverageMessageData and ResourceUnitRanking (apache#24772) (cherry picked from commit 7504538)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24754
Motivation
java.lang.IllegalArgumentException: Comparison method violates its general contract!ifcompareTodoesn't meet the contract ofComparable.compareTointerfaceThe contract of
Comparable.compareTo:The implementor must ensure signum(x.compareTo(y)) == -signum(y.compareTo(x)) for all x and y. (This implies that x.compareTo(y) must throw an exception if and only if y.compareTo(x) throws an exception.)
The implementor must also ensure that the relation is transitive: (x.compareTo(y) > 0 && y.compareTo(z) > 0) implies x.compareTo(z) > 0.
Finally, the implementor must ensure that x.compareTo(y)==0 implies that signum(x.compareTo(z)) == signum(y.compareTo(z)), for all z.
Modifications
Comparable.compareTocontract by using a difference.compareTofor NamespaceBundleStats and TimeAverageMessageDatacompareTomethod tocompareToOtherRankingand remove theComparableinterface since ResourceUnitRanking cannot fulfill the contract and there isn't a need to do so. Removing the interface and new comments in thecompareToOtherRankingmethod will help prevent possible misuse later. The current usage of ResourceUnitRanking's method is fine, it's just not requiring Comparable.compareTo semantics and contract. That's why it's better to rename the method.Documentation
docdoc-requireddoc-not-neededdoc-complete