[fix][test] Flaky-test: BrokerServiceTest.testShutDownWithMaxConcurrentUnload #24769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntUnload Revise `BrokerServiceTest.testShutDownWithMaxConcurrentUnload`, since apache#24731 fixed the issue where the broker couldn’t be shut down via Pulsar Admin. The original test contains a race condition in its assertion. ```java admin.brokers().shutDownBrokerGracefully(1, false); Awaitility.await().atLeast(bundleNum - 1, TimeUnit.SECONDS).untilAsserted(() -> { assertEquals(pulsar.getBrokerService().getTopics().size(), 0); // race condition: pulsar.getBrokerService() is possibly be null because the broker is shutting down }); ```
Technoboy-
approved these changes
Sep 20, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24769 +/- ##
============================================
+ Coverage 74.10% 74.27% +0.16%
- Complexity 33607 33640 +33
============================================
Files 1901 1901
Lines 148403 148403
Branches 17204 17204
============================================
+ Hits 109972 110219 +247
+ Misses 29646 29390 -256
- Partials 8785 8794 +9
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 26, 2025
…ntUnload (apache#24769) (cherry picked from commit 0c6ba1c) (cherry picked from commit 2d68d84)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 26, 2025
…ntUnload (apache#24769) (cherry picked from commit 0c6ba1c) (cherry picked from commit 2d68d84)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 29, 2025
…ntUnload (apache#24769) (cherry picked from commit 0c6ba1c) (cherry picked from commit b4ba39c)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 29, 2025
…ntUnload (apache#24769) (cherry picked from commit 0c6ba1c) (cherry picked from commit b4ba39c)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Oct 30, 2025
…ntUnload (apache#24769) (cherry picked from commit 0c6ba1c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24765
Motivation
Revise
BrokerServiceTest.testShutDownWithMaxConcurrentUnload, since #24731 fixed the issue where the broker couldn’t be shut down via pulsar admin. The original test contains a race condition in its assertion.Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: