Skip to content

[fix][broker][branch-3.0] Prevent NPE in ownedBundlesCountPerNamespace on first bundle load #24758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodece merged 1 commit into from
Sep 18, 2025
Merged

[fix][broker][branch-3.0] Prevent NPE in ownedBundlesCountPerNamespace on first bundle load #24758

nodece merged 1 commit into from
Sep 18, 2025
+7 −7

Conversation

@nodece
Copy link
Member

@nodece nodece commented Sep 18, 2025

Motivation

Fix NPE:

java.lang.NullPointerException: Cannot invoke "java.util.concurrent.atomic.AtomicInteger.incrementAndGet()" because the return value of "java.util.Map.get(Object)" is null

  at org.apache.pulsar.broker.service.SystemTopicBasedTopicPoliciesService.addOwnedNamespaceBundleAsync(SystemTopicBasedTopicPoliciesService.java:405) ~[pulsar-broker.jar:3.0.14-SNAPSHOT]

  at org.apache.pulsar.broker.service.SystemTopicBasedTopicPoliciesService$2.onLoad(SystemTopicBasedTopicPoliciesService.java:509) ~[pulsar-broker.jar:3.0.14-SNAPSHOT]

  at org.apache.pulsar.broker.namespace.NamespaceService.notifyNamespaceBundleOwnershipListener(NamespaceService.java:1322) ~[pulsar-broker.jar:3.0.14-SNAPSHOT]

  at org.apache.pulsar.broker.namespace.NamespaceService.onNamespaceBundleOwned(NamespaceService.java:1285) ~[pulsar-broker.jar:3.0.14-SNAPSHOT]

  at org.apache.pulsar.broker.namespace.OwnershipCache.lambda$tryAcquiringOwnership$3(OwnershipCache.java:218) ~[pulsar-broker.jar:3.0.14-SNAPSHOT]

  at java.util.concurrent.CompletableFuture.uniApplyNow(CompletableFuture.java:684) ~[?:?]

  at java.util.concurrent.CompletableFuture.uniApplyStage(CompletableFuture.java:662) ~[?:?]

  at java.util.concurrent.CompletableFuture.thenApply(CompletableFuture.java:2168) ~[?:?]

  at org.apache.pulsar.broker.namespace.OwnershipCache.tryAcquiringOwnership(OwnershipCache.java:216) ~[pulsar-broker.jar:3.0.14-SNAPSHOT]

  at org.apache.pulsar.broker.namespace.NamespaceService.searchForCandidateBroker(NamespaceService.java:631) ~[pulsar-broker.jar:3.0.14-SNAPSHOT]

  at org.apache.pulsar.broker.namespace.NamespaceService.lambda$findBrokerServiceUrl$10(NamespaceService.java:466) ~[pulsar-broker.jar:3.0.14-SNAPSHOT]

  at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) ~[?:?]

  at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]

  at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) ~[?:?]

  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]

  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]

  at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[netty-common-4.1.124.Final.jar:4.1.124.Final]

  at java.lang.Thread.run(Thread.java:840) ~[?:?]

Modifications

  • Replaced direct ownedBundlesCountPerNamespace.get(...).incrementAndGet() with
    computeIfAbsent(namespace, k -> new AtomicInteger(0)) to ensure the counter is always initialized before incrementing.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 18, 2025
@nodece nodece mentioned this pull request Sep 18, 2025
Merged
4 tasks
@lhotari lhotari changed the title [fix][broker] Prevent NPE in ownedBundlesCountPerNamespace on first bundle load [fix][broker][branch-3.0] Prevent NPE in ownedBundlesCountPerNamespace on first bundle load Sep 18, 2025
lhotari
lhotari approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodece nodece merged commit 6ceb4f8 into apache:branch-3.0 Sep 18, 2025
64 of 68 checks passed
@nodece nodece deleted the fix-NPE-ownedBundlesCountPerNamespace branch September 18, 2025 09:17
nodece added a commit to ascentstream/pulsar that referenced this pull request Sep 19, 2025
@nodece
[fix][broker][branch-3.0] Prevent NPE in ownedBundlesCountPerNamespac…
8436cb7 
…e on first bundle load (apache#24758)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Sep 19, 2025
@nodece @manas-ctds
[fix][broker][branch-3.0] Prevent NPE in ownedBundlesCountPerNamespac…
52b50d4 
…e on first bundle load (apache#24758)

(cherry picked from commit 6ceb4f8)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Sep 19, 2025
@nodece @srinath-ctds
[fix][broker][branch-3.0] Prevent NPE in ownedBundlesCountPerNamespac…
58c31d9 
…e on first bundle load (apache#24758)

(cherry picked from commit 6ceb4f8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhotari lhotari lhotari approved these changes

Assignees

No one assigned

Labels

doc-not-needed Your PR changes do not impact docs release/3.3.10

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nodece @lhotari