[fix][broker] Fix testServiceConfigurationRetentionPolicy unit test #24756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
approved these changes
Sep 17, 2025
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24756 +/- ##
============================================
+ Coverage 73.64% 74.22% +0.57%
- Complexity 2472 33253 +30781
============================================
Files 1900 1900
Lines 148427 148430 +3
Branches 17209 17207 -2
============================================
+ Hits 109314 110173 +859
+ Misses 30330 29474 -856
Partials 8783 8783
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Technoboy-
approved these changes
Sep 18, 2025
Technoboy-
pushed a commit
that referenced
this pull request
Sep 18, 2025
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 18, 2025
…pache#24756) (cherry picked from commit 63331ca) (cherry picked from commit a855054)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 18, 2025
…pache#24756) (cherry picked from commit 63331ca) (cherry picked from commit a855054)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix unit test due to this PR: #24733
Also see comments: 437d9f6#r165951071
Modifications
Fix and add unit test.
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: