-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][client] rollback TopicListWatcher retry behavior #24752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lhotari
merged 4 commits into
apache:master
from
oneby-wang:TopicListWatcher_behavior_rollback
Sep 17, 2025
Merged
[fix][client] rollback TopicListWatcher retry behavior #24752
lhotari
merged 4 commits into
apache:master
from
oneby-wang:TopicListWatcher_behavior_rollback
Sep 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
approved these changes
Sep 17, 2025
Member
lhotari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Member
|
Good work @oneby-wang |
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Contributor
Author
|
Thanks for reviewing code and helping me understand the logic. @lhotari |
Technoboy-
pushed a commit
that referenced
this pull request
Sep 18, 2025
Co-authored-by: oneby-wang <onebywang@qq.com>
lhotari
pushed a commit
that referenced
this pull request
Sep 18, 2025
Co-authored-by: oneby-wang <onebywang@qq.com> (cherry picked from commit 1300f0a)
lhotari
pushed a commit
that referenced
this pull request
Sep 18, 2025
Co-authored-by: oneby-wang <onebywang@qq.com> (cherry picked from commit 1300f0a)
lhotari
pushed a commit
that referenced
this pull request
Sep 18, 2025
Co-authored-by: oneby-wang <onebywang@qq.com> (cherry picked from commit 1300f0a)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Sep 19, 2025
Co-authored-by: oneby-wang <onebywang@qq.com> (cherry picked from commit 1300f0a)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
Co-authored-by: oneby-wang <onebywang@qq.com>
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Co-authored-by: oneby-wang <onebywang@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
cherry-picked/branch-4.1
doc-not-needed
Your PR changes do not impact docs
release/3.0.14
release/3.3.9
release/4.0.7
release/4.1.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24707
Motivation
Rollback TopicListWatcher retry behavior in PR #24698
Modifications
Rollback TopicListWatcher retry behavior to avoid "breaking change".
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: oneby-wang#3