Skip to content

Conversation

@oneby-wang
Copy link
Contributor

@oneby-wang oneby-wang commented Sep 17, 2025

Fixes #24707

Motivation

Rollback TopicListWatcher retry behavior in PR #24698

Modifications

Rollback TopicListWatcher retry behavior to avoid "breaking change".

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: oneby-wang#3

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari
Copy link
Member

lhotari commented Sep 17, 2025

Good work @oneby-wang

@oneby-wang
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@lhotari lhotari merged commit 1300f0a into apache:master Sep 17, 2025
98 of 102 checks passed
@oneby-wang
Copy link
Contributor Author

Thanks for reviewing code and helping me understand the logic. @lhotari

@lhotari lhotari added this to the 4.2.0 milestone Sep 17, 2025
Technoboy- pushed a commit that referenced this pull request Sep 18, 2025
Co-authored-by: oneby-wang <onebywang@qq.com>
lhotari pushed a commit that referenced this pull request Sep 18, 2025
Co-authored-by: oneby-wang <onebywang@qq.com>
(cherry picked from commit 1300f0a)
lhotari pushed a commit that referenced this pull request Sep 18, 2025
Co-authored-by: oneby-wang <onebywang@qq.com>
(cherry picked from commit 1300f0a)
lhotari pushed a commit that referenced this pull request Sep 18, 2025
Co-authored-by: oneby-wang <onebywang@qq.com>
(cherry picked from commit 1300f0a)
ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Sep 18, 2025
Co-authored-by: oneby-wang <onebywang@qq.com>
(cherry picked from commit 1300f0a)
(cherry picked from commit 5f7c8e6)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Sep 18, 2025
Co-authored-by: oneby-wang <onebywang@qq.com>
(cherry picked from commit 1300f0a)
(cherry picked from commit 5f7c8e6)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Sep 19, 2025
Co-authored-by: oneby-wang <onebywang@qq.com>
(cherry picked from commit 1300f0a)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Sep 19, 2025
Co-authored-by: oneby-wang <onebywang@qq.com>
(cherry picked from commit 1300f0a)
(cherry picked from commit b060fa9)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Sep 19, 2025
Co-authored-by: oneby-wang <onebywang@qq.com>
(cherry picked from commit 1300f0a)
(cherry picked from commit b060fa9)
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] TopicListWatcher retry behavior was changed in PR #24698

3 participants