[fix][client] Fix receiver queue auto-scale without memory limit #24743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
approved these changes
Sep 15, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24743 +/- ##
============================================
- Coverage 74.29% 74.20% -0.10%
- Complexity 33140 33603 +463
============================================
Files 1895 1900 +5
Lines 147979 148403 +424
Branches 17137 17206 +69
============================================
+ Hits 109942 110119 +177
- Misses 29317 29495 +178
- Partials 8720 8789 +69
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
lhotari
pushed a commit
that referenced
this pull request
Sep 16, 2025
) (cherry picked from commit 8e35e34)
lhotari
pushed a commit
that referenced
this pull request
Sep 16, 2025
) (cherry picked from commit 8e35e34)
lhotari
pushed a commit
that referenced
this pull request
Sep 16, 2025
) (cherry picked from commit 8e35e34)
lhotari
pushed a commit
that referenced
this pull request
Sep 16, 2025
) (cherry picked from commit 8e35e34)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Sep 16, 2025
…che#24743) (cherry picked from commit 8e35e34)
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 18, 2025
…che#24743) (cherry picked from commit 8e35e34) (cherry picked from commit 298bba4)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 18, 2025
…che#24743) (cherry picked from commit 8e35e34) (cherry picked from commit 298bba4)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 19, 2025
…che#24743) (cherry picked from commit 8e35e34) (cherry picked from commit c1e9bb2)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 19, 2025
…che#24743) (cherry picked from commit 8e35e34) (cherry picked from commit c1e9bb2)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24694
Motivation
When the MemoryLimitController calculates the memory usage percentage, a division by 0 happens in case the memory limit is set to 0 / disabled. The current behaviour is that the percentage then is NaN.
Modifications
This PR changes the behaviour so that the percentage is always 0 in case the memory limit is 0.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: pdolif#14