[fix][broker] First entry will be skipped if opening NonDurableCursor while trimmed ledger is adding first entry. #24738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edger is adding first entry after trimmed.
|
@zhouyifan279 Please add the following content to your PR description and select a checkbox: |
lhotari
reviewed
Sep 16, 2025
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/NonDurableCursorTest.java
Outdated
Show resolved
Hide resolved
BewareMyPower
approved these changes
Sep 16, 2025
…l/NonDurableCursorTest.java Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24738 +/- ##
============================================
- Coverage 74.28% 74.18% -0.10%
- Complexity 33256 33605 +349
============================================
Files 1900 1901 +1
Lines 148398 148366 -32
Branches 17208 17200 -8
============================================
- Hits 110231 110072 -159
- Misses 29392 29522 +130
+ Partials 8775 8772 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
… while trimmed ledger is adding first entry. (apache#24738) Co-authored-by: Yunze Xu <xyzinfernity@163.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 26, 2025
… while trimmed ledger is adding first entry. (apache#24738) Co-authored-by: Yunze Xu <xyzinfernity@163.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 7a120f3) (cherry picked from commit 0e4e54b)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 26, 2025
… while trimmed ledger is adding first entry. (apache#24738) Co-authored-by: Yunze Xu <xyzinfernity@163.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 7a120f3) (cherry picked from commit 0e4e54b)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 29, 2025
… while trimmed ledger is adding first entry. (apache#24738) Co-authored-by: Yunze Xu <xyzinfernity@163.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 7a120f3) (cherry picked from commit f427b97)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 29, 2025
… while trimmed ledger is adding first entry. (apache#24738) Co-authored-by: Yunze Xu <xyzinfernity@163.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 7a120f3) (cherry picked from commit f427b97)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
… while trimmed ledger is adding first entry. (apache#24738) Co-authored-by: Yunze Xu <xyzinfernity@163.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Oct 30, 2025
… while trimmed ledger is adding first entry. (apache#24738) Co-authored-by: Yunze Xu <xyzinfernity@163.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 7a120f3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24737
Motivation
Pulsar ProtocolHandler, such as KoP, uses
ManagedLedgerImpl#asyncFindPositionto findstartCursorPositionand create a NonDurableCursor.When a topic's ledger is trimmed and is empty,
startCursorPositionwill be (currentLedgerId, -1).However, the created NonDurableCursor's readPosition is not stable if Topic ledger is adding a new entry simultaneously.
It may be (currentLedgerId, 0) or (currentLedgerId, 2).
We expect the created NonDurableCursor readPosition to always be (currentLedgerId, 0).
Modifications
In NonDurableCursorImpl constructor, we declare a reference to
ManagedLedgerImpl#lastConfirmedEntryand use it to compare withstartCursorPositionand toinitializeCursorPosition.Verifying this change
Run new test
NonDurableCursorTest#testOpenNonDurableCursorWhileLedgerIsAddingFirstEntryAfterTrimmedDoes this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: zhouyifan279#2