[fix][client] Fix PulsarAdmin description check and add test #24734
+36
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a missing validation in PulsarAdmin's description field and adds comprehensive test coverage. The fix ensures that client descriptions are limited to 64 characters, matching the existing validation in PulsarClient.
- Add description length validation (64 character limit) to PulsarAdminBuilderImpl
- Add test coverage for valid and invalid description lengths for both PulsarClient and PulsarAdmin
- Remove orphaned test from PulsarAdminImplTest that was moved to the appropriate test class
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| PulsarAdminBuilderImpl.java | Added description length validation with 64 character limit |
| ClientBuilderImplTest.java | Added tests for valid description and description length validation |
| PulsarAdminBuilderImplTest.java | Added tests for valid description and description length validation |
| PulsarAdminImplTest.java | Removed misplaced test that belonged in builder test class |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...-admin/src/test/java/org/apache/pulsar/client/admin/internal/PulsarAdminBuilderImplTest.java
Outdated
Show resolved
Hide resolved
4 tasks
7839b3e to
12850d0
Compare
lhotari
approved these changes
Sep 12, 2025
BewareMyPower
approved these changes
Sep 12, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24734 +/- ##
=============================================
+ Coverage 38.32% 74.15% +35.82%
- Complexity 13038 33222 +20184
=============================================
Files 1843 1900 +57
Lines 144271 148379 +4108
Branches 16730 17204 +474
=============================================
+ Hits 55292 110030 +54738
+ Misses 81463 29559 -51904
- Partials 7516 8790 +1274
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
lhotari
pushed a commit
that referenced
this pull request
Oct 6, 2025
(cherry picked from commit 8d7a28c)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#24729 adds the client description for PulsarAdmin, which didn't consider the description length.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete