[feat][fn] Fallback to using STATE_STORAGE_SERVICE_URL in PulsarMetadataStateStoreProviderImpl.init
#24721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tadataStateStoreProviderImpl.init
Member
|
@jiangpengcheng Do you have a chance to add a new integration test where this problem gets reproduced and where this fix addresses it? |
Technoboy-
approved these changes
Sep 10, 2025
Contributor
Author
sure, I will add some integration tests |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24721 +/- ##
============================================
+ Coverage 74.17% 74.19% +0.02%
- Complexity 33470 33502 +32
============================================
Files 1895 1896 +1
Lines 148029 148111 +82
Branches 17142 17164 +22
============================================
+ Hits 109796 109891 +95
+ Misses 29479 29446 -33
- Partials 8754 8774 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
|
Great work @jiangpengcheng |
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 12, 2025
…tadataStateStoreProviderImpl.init` (apache#24721) (cherry picked from commit 415c6fa) (cherry picked from commit 3ec5e64)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 12, 2025
…tadataStateStoreProviderImpl.init` (apache#24721) (cherry picked from commit 415c6fa) (cherry picked from commit 3ec5e64)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…tadataStateStoreProviderImpl.init` (apache#24721)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…tadataStateStoreProviderImpl.init` (apache#24721)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24720
Motivation
The
PulsarMetadataStateStoreProviderImpl.initmethod fetches theMETADATA_URLfield from the config argument, but it doesn't exist in normal case, fallback tostateStorageServiceUrljust like otherStateStoreProviderImplModifications
When the provided argument doesn't contains a
METADATA_URLfield, fallback to fetching with keystateStorageServiceUrlVerifying this change
Make sure that the change passes the CI checks.
added new integration tests in:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: jiangpengcheng#47