[fix][broker] Fix memory leak when metrics are updated in a thread other than FastThreadLocalThread #24719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @oneby-wang BTW, the archived open source KoP fixes this issue by remembering the Netty I/O executor everywhere and updating the metrics in that executor. See https://github.com/streamnative/kop/pull/2006/files However, this solution is error-prone because it's easy to miss such pattern. |
lhotari
reviewed
Sep 9, 2025
...c/main/java/org/apache/pulsar/broker/stats/prometheus/metrics/DataSketchesOpStatsLogger.java
Show resolved
Hide resolved
lhotari
reviewed
Sep 9, 2025
...ker/src/main/java/org/apache/pulsar/broker/stats/prometheus/metrics/ThreadLocalAccessor.java
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24719 +/- ##
============================================
+ Coverage 74.17% 74.18% +0.01%
- Complexity 33473 33494 +21
============================================
Files 1895 1896 +1
Lines 148023 148025 +2
Branches 17140 17148 +8
============================================
+ Hits 109790 109813 +23
+ Misses 29471 29456 -15
+ Partials 8762 8756 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
lhotari
approved these changes
Sep 9, 2025
Technoboy-
pushed a commit
that referenced
this pull request
Sep 10, 2025
…her than FastThreadLocalThread (#24719)
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Sep 10, 2025
…her than FastThreadLocalThread (apache#24719)
Technoboy-
pushed a commit
that referenced
this pull request
Sep 10, 2025
…her than FastThreadLocalThread (#24719)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 11, 2025
…her than FastThreadLocalThread (apache#24719) (cherry picked from commit e241b0a)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 12, 2025
…her than FastThreadLocalThread (apache#24719) (cherry picked from commit e241b0a)
nborisov
pushed a commit
to nborisov/pulsar
that referenced
this pull request
Sep 12, 2025
…her than FastThreadLocalThread (apache#24719)
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 15, 2025
…her than FastThreadLocalThread (apache#24719) (cherry picked from commit 9715653) (cherry picked from commit cb5a3ab)
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 15, 2025
…her than FastThreadLocalThread (apache#24719) (cherry picked from commit 9715653) (cherry picked from commit cb5a3ab)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 15, 2025
…her than FastThreadLocalThread (apache#24719) (cherry picked from commit 9715653) (cherry picked from commit cb5a3ab)
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Sep 16, 2025
…her than FastThreadLocalThread (apache#24719) (cherry picked from commit 9715653)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…her than FastThreadLocalThread (apache#24719)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…her than FastThreadLocalThread (apache#24719)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #24714 (comment)
Currently this issue rarely happens because most metrics updates happen in Netty I/O threads when handling requests. However,
DataSketchesOpStatsLoggerandDataSketchesSummaryLoggerare public and can be used by downstream plugins (e.g. protocol handlers).Modifications
recordmethod toLocalDataandThreadLocalAccessorresponsible for updating the metrics.ThreadLocalAccessorTestto verify when the metrics are updated in a normal thread (notFastThreadLocalRunnable), theLocalDataobjects won't be removed from the map inThreadLocalAccessorLocalDatain a non-Netty thread and remove it from the map if it's garbage collected or not alive when iterating the whole map called byrotateLatencyCollection.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: