[improve][ml] Improve cache insert performance by removing exists check since it's already covered by putIfAbsent #24699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck since it's already covered by putIfAbsent
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24699 +/- ##
============================================
- Coverage 74.33% 74.20% -0.13%
+ Complexity 33534 33479 -55
============================================
Files 1895 1895
Lines 147954 147952 -2
Branches 17130 17129 -1
============================================
- Hits 109978 109795 -183
- Misses 29256 29420 +164
- Partials 8720 8737 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dao-jun
approved these changes
Sep 4, 2025
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…ck since it's already covered by putIfAbsent (apache#24699)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…ck since it's already covered by putIfAbsent (apache#24699)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While profiling Pulsar with PulsarProfilingTest, I noticed that a significant part of CPU of an insert to the cache is spent in the existence check. The case where the entry might already be in the cache is already covered by putIfAbsent and it is very rare after the PendingReadsManager solution was introduced to de-duplicate reads. PIP-430 caches also include a cache lookup for all entries before performing a read and reads from storage will happen only for missing entries.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete