Skip to content

Conversation

@mattisonchao
Copy link
Member

Motivation

Upgrade the oxia-java client version to 0.6.1 to apply the latest fixes.

Modifications

  • upgrade oxia-java client version

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@mattisonchao mattisonchao self-assigned this Aug 30, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Aug 30, 2025
@mattisonchao mattisonchao reopened this Aug 30, 2025
@lhotari
Copy link
Member

lhotari commented Aug 30, 2025

@mattisonchao

LockManagerTest.acquireLocks:56 » NoClassDefFound Could not initialize class io.oxia.proto.ShardAssignmentsRequest

@lhotari
Copy link
Member

lhotari commented Aug 30, 2025

@mattisonchao The protobuf version used in oxia-client-java isn't compatible with Pulsar's protobuf version:
https://github.com/oxia-db/oxia-client-java/blob/e1ecf0a95b8df36e6bf7b13981540d2c4e786b9a/pom.xml#L79
There was a major version bump in protobuf from 3.x to 4.x fairly recently and it seems that there's no compatibility any more. Here's the announcement:
https://protobuf.dev/news/v26/#breaking-compatibility-with-old-generated-code

One possible way to solve this would be to have multiple sub modules in oxia-client-java for different protobuf versions.
The default could be for 4.x, but it could be possible to exclude the dependency and replace it with another dependency.

@mattisonchao mattisonchao changed the title [feat][misc] upgrade oxia version to 0.6.1 [feat][misc] upgrade oxia version to 0.6.2 Sep 1, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.17%. Comparing base (4a4e692) to head (ea8e8a4).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24689      +/-   ##
============================================
- Coverage     74.38%   74.17%   -0.21%     
+ Complexity    33105    33084      -21     
============================================
  Files          1893     1895       +2     
  Lines        147811   147954     +143     
  Branches      17098    17130      +32     
============================================
- Hits         109950   109749     -201     
- Misses        29149    29459     +310     
- Partials       8712     8746      +34     
Flag Coverage Δ
inttests 26.30% <ø> (-0.68%) ⬇️
systests 22.69% <ø> (-0.16%) ⬇️
unittests 73.68% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 105 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattisonchao mattisonchao merged commit fcd5f92 into master Sep 1, 2025
97 of 99 checks passed
mattisonchao added a commit that referenced this pull request Sep 1, 2025
mattisonchao added a commit that referenced this pull request Sep 1, 2025
@lhotari lhotari deleted the oxia.upgrade.0.6.1 branch September 2, 2025 11:55
@lhotari
Copy link
Member

lhotari commented Sep 4, 2025

@mattisonchao This depends on #24438 for branch-3.0 and branch-3.3 . Is there a need to update Oxia support in those branches?

Technoboy- pushed a commit to Technoboy-/pulsar that referenced this pull request Sep 10, 2025
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Sep 11, 2025
(cherry picked from commit fcd5f92)
(cherry picked from commit d81fa9b)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Sep 12, 2025
(cherry picked from commit fcd5f92)
(cherry picked from commit d81fa9b)
nborisov pushed a commit to nborisov/pulsar that referenced this pull request Sep 12, 2025
@lhotari lhotari added this to the 4.2.0 milestone Sep 17, 2025
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants