-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve][build] Use org.apache.nifi:nifi-nar-maven-plugin:2.1.0 with skipDocGeneration=true #24668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][build] Use org.apache.nifi:nifi-nar-maven-plugin:2.1.0 with skipDocGeneration=true #24668
Conversation
… skipDocGeneration=true, when build JVM is Java 21+
|
Example of the build stalling due to NiFi nar plugin documentation generation: This PR will resolve this issue as long as the build JVM is Java 21. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24668 +/- ##
============================================
+ Coverage 74.01% 74.27% +0.26%
+ Complexity 33224 33208 -16
============================================
Files 1858 1885 +27
Lines 146500 146943 +443
Branches 16880 16927 +47
============================================
+ Hits 108425 109144 +719
+ Misses 29394 29100 -294
- Partials 8681 8699 +18
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
… skipDocGeneration=true (apache#24668) (cherry picked from commit a239240)
… skipDocGeneration=true (apache#24668) (cherry picked from commit a239240) (cherry picked from commit 44ca073)
… skipDocGeneration=true (apache#24668) (cherry picked from commit a239240) (cherry picked from commit efaeef9)
… skipDocGeneration=true (apache#24668) (cherry picked from commit a239240) (cherry picked from commit efaeef9)
… skipDocGeneration=true (apache#24668) (cherry picked from commit a239240)
… skipDocGeneration=true (apache#24668) (cherry picked from commit a239240) (cherry picked from commit 44ca073)
… skipDocGeneration=true (apache#24668) (cherry picked from commit a239240)
… skipDocGeneration=true (apache#24668)
… skipDocGeneration=true (apache#24668)
Motivation
The nifi-nar-maven-plugin will generate NiFi specific documentation when the NAR file is created. Pulsar doesn't use this documentation and it's a waste of resources to attempt to generate the documentation which requires a heavy classloading and scanning process.
Since org.apache.nifi:nifi-nar-maven-plugin:2.0.0, it has been possible to skip the documentation generation, thanks to @nicoloboschi's PR apache/nifi-maven#35. The challenge with nifi-nar-maven-plugin 2.0.0+ version is that it requires Java 21+. This PR solves that challenge.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete