Motivation

#23795 improved the method recentlyJoinedConsumers: rather than check ordering for all items, just check the latest two because the method will be called after addition for all consumers.

The method sortRecentlyJoinedConsumersIfNeeded has a bug; it did an unnecessary sorting for the collection recentlyJoinedConsumers, and printed noisy logs The items in recentlyJoinedConsumers are out-of-order.

For example:

• there are 3 items: [1, 2, 3]
• the first loop: posPre -> 1
• the second loop: posPre -> null; posAfter -> 2
• the latest loop: posPre -> 3; Since the variable posPre is null , skip to set the variable posAfter

        // Record the second latest item.
        Position posPre = null;
        // Record the latest item.
        Position posAfter = null;
        for (Map.Entry<Consumer, Position> entry : recentlyJoinedConsumers.entrySet()) {
            if (posPre == null) {
                posPre = entry.getValue();
            } else {
                posPre = posAfter; // Issue: the variable "posPre" will be set to "null" at the second loop
                posAfter = entry.getValue();
            }
        }

Modifications

Fix the issue.

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: x