[fix][test]fix flaky ZeroQueueSizeTest.testZeroQueueGetExceptionWhenReceiveBatchMessage #24633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
approved these changes
Aug 17, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24633 +/- ##
============================================
- Coverage 74.48% 74.35% -0.14%
+ Complexity 33277 32816 -461
============================================
Files 1882 1882
Lines 146854 146854
Branches 16866 16866
============================================
- Hits 109389 109198 -191
- Misses 28861 28997 +136
- Partials 8604 8659 +55
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 20, 2025
…eceiveBatchMessage (apache#24633) (cherry picked from commit 65607ab) (cherry picked from commit 4cca9c9)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 20, 2025
…eceiveBatchMessage (apache#24633) (cherry picked from commit 65607ab) (cherry picked from commit 4cca9c9)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 21, 2025
…eceiveBatchMessage (apache#24633) (cherry picked from commit 65607ab) (cherry picked from commit 1c904db)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 26, 2025
…eceiveBatchMessage (apache#24633) (cherry picked from commit 65607ab) (cherry picked from commit 1c904db)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Aug 26, 2025
…eceiveBatchMessage (apache#24633) (cherry picked from commit 65607ab)
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Sep 10, 2025
…eceiveBatchMessage (apache#24633) (cherry picked from commit 65607ab)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…eceiveBatchMessage (apache#24633)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…eceiveBatchMessage (apache#24633)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24629
Motivation
ZeroQueueSizeTest.testZeroQueueGetExceptionWhenReceiveBatchMessageuse same topicName(persistent://prop-xyz/use/ns-abc/topic1) asZeroQueueSizeTest.testFailedZeroQueueSizeBatchMessage, SincetestFailedZeroQueueSizeBatchMessagesends some non-batch messages, it interferes with this test's behavior.Modifications
changing tests which using same topicName to use unique topicName:
ZeroQueueSizeTest#testZeroQueueGetExceptionWhenReceiveBatchMessageSimpleProducerConsumerTest#consumerReceiveThrowExceptionWhenConsumerCloseSimpleProducerConsumerTest#multiThreadConsumerReceiveThrowExceptionWhenConsumerCloseVerifying this change
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: 3pacccccc#23